Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip for non vs topologies in test_vs_chassis_setup.py #14701

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Javier-Tan
Copy link

@Javier-Tan Javier-Tan commented Sep 24, 2024

Description of PR

Summary:
Fixes #14722 (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Stop tests in test_vs_chassis_setup from failing on non vs_chassis.

How did you do it?

Add pytest skip flag in test setup if 'vs_chassis' not in DUT topo properties.

How did you verify/test it?

Ran test on physical T2 testbed to verify it skips.

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

Copy link

linux-foundation-easycla bot commented Sep 24, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: test_vs_chassis_setup.py should not run and fail on non vs_chassis topologies
1 participant