Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ecmp_sai_value] Enhancement #14708

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

link19430
Copy link
Contributor

@link19430 link19430 commented Sep 24, 2024

Description of PR

Summary:

  1. Add systemctl reset-failed before restart service.
  2. Skip unsupported topology for test_ecmp_hash_seed_value[warm-reboot]
  3. Enhance check_ecmp_offset_value

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Sometimes the test failed at case - restart_syncd

How did you do it?

Add systemctl reset-failed before restart service.

How did you verify/test it?

Execute thet test case

Any platform specific information?

None

Supported testbed topology if it's a new test case?

None

Documentation

1. Add systemctl reset-failed before restart service.
2. Skip unsupported topology for test_ecmp_hash_seed_value[warm-reboot]
3. Enhance check_ecmp_offset_value
@link19430
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gord1306
Copy link
Contributor

gord1306 commented Oct 8, 2024

@StormLiangMS @ZhaohuiS Could you help to review this PR. Thanks.

Copy link
Contributor

@ZhaohuiS ZhaohuiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, thank you for the fix and enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants