[Bugfix] Fix NameError imported by PR #14672 #14723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxin
approved these changes
Sep 25, 2024
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
What is the motivation for this PR? In PR sonic-net#14672, we moved some functions from platform_tests/verify_dut_health.py to common/platform/device_utils.py, but forgot to move the defination of variable test_report, which will cause an NameError. In this PR, we define this variable in common/platform/device_utils.py to fix this issue. How did you do it? Define the variable in common/platform/device_utils.py to fix this issue.
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Oct 10, 2024
What is the motivation for this PR? In PR sonic-net#14672, we moved some functions from platform_tests/verify_dut_health.py to common/platform/device_utils.py, but forgot to move the defination of variable test_report, which will cause an NameError. In this PR, we define this variable in common/platform/device_utils.py to fix this issue. How did you do it? Define the variable in common/platform/device_utils.py to fix this issue.
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
What is the motivation for this PR? In PR sonic-net#14672, we moved some functions from platform_tests/verify_dut_health.py to common/platform/device_utils.py, but forgot to move the defination of variable test_report, which will cause an NameError. In this PR, we define this variable in common/platform/device_utils.py to fix this issue. How did you do it? Define the variable in common/platform/device_utils.py to fix this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
In PR #14672, we moved some functions from
platform_tests/verify_dut_health.pytocommon/platform/device_utils.py, but forgot to move the defination of variabletest_report, which will cause an NameError. In this PR, we define this variable incommon/platform/device_utils.pyto fix this issue.Summary:
Fixes #14672
Type of change
Back port request
Approach
What is the motivation for this PR?
In PR #14672, we moved some functions from
platform_tests/verify_dut_health.pytocommon/platform/device_utils.py, but forgot to move the defination of variabletest_report, which will cause an NameError. In this PR, we define this variable incommon/platform/device_utils.pyto fix this issue.How did you do it?
Define the variable in
common/platform/device_utils.pyto fix this issue.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation