Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform_tests/counterpoll]: Don't run counterpoll_watermark test on supervisor #14724

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liamkearney-msft
Copy link

  • Select only frontend hwskus for counterpoll_queue_watermark_pg_drop test
  • Assert if waiting for COUNTER_DB to be populated fails

BugLink: #14721

Summary:
Fixes #14721

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

platform test test_counterpoll_watermark_pg_drop runs and fails on the sup cards, where it should only be running on linecards. Test case fixture needs to be modified to only select frontend cards. Additionally, the test should fail if it fails to wait on the COUNTER_DB on becoming populated

How did you do it?

How did you verify/test it?

Run on testbed - successfully skips supervisor, and asserts properly if the counter_db is not populated

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Copy link

linux-foundation-easycla bot commented Sep 25, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: liamkearney-msft (1585488)

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/platform_tests/counterpoll/test_counterpoll_watermark.py:128:21: E128 continuation line under-indented for visual indent

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

… supervisor

* Select only frontend hwskus for counterpoll_queue_watermark_pg_drop test
* Assert if waiting for COUNTER_DB to be populated fails

BugLink: sonic-net#14721
Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: counterpoll_watermark test should not run on supervisor
2 participants