[action] [PR:14673] feat: add multi-asic in test_cont_link_flap #14726
+47
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description of PR
Currently, test_cont_link_flap is not compatible with multi-asic. It's failing on vtysh command
raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
{"changed": true, "cmd": "vtysh -c \"show memory bgpd\"", "delta": "0:00:00.006507", "end": "2024-09-17 00:06:50.914882", "failed": true, "msg": "non-zero return code", "rc": 1, "start": "2024-09-17 00:06:50.908375", "stderr": "Usage: /usr/bin/vtysh -n [0 to 2] [OPTION]... ", "stderr_lines": ["Usage: /usr/bin/vtysh -n [0 to 2] [OPTION]... "], "stdout": "", "stdout_lines": []}
This is because for multi-asic platform, we need to specify -n.
Summary: add multi-asic support for test_cont_link_flap
Fixes # (issue) 2954952
Approach
What is the motivation for this PR?
Support multi-asic for test_cont_link_flap by calculating the memory based of each individual asic
How did you do it?
Since SonicAsic.run_asic has already provided a back-ward compatible to multi-asic and single-asic (https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/devices/sonic_asic.py#L404) we can leverage this API to execute the test.
The test is also working with single-asic since in our system, single-asic chassis will have 1 asic with namespace=None and asic-index=0
How did you verify/test it?
Verified on T2 device and T0 kms
Signed-off-by: Austin Pham <austinpham@microsoft.com>
8 tasks
|
Original PR: #14673 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Currently, test_cont_link_flap is not compatible with multi-asic. It's failing on vtysh command
This is because for multi-asic platform, we need to specify
-n.Summary: add multi-asic support for test_cont_link_flap
Fixes # (issue) 2954952
Type of change
Back port request
Approach
What is the motivation for this PR?
Support multi-asic for test_cont_link_flap by calculating the memory based of each individual asic
How did you do it?
Since
SonicAsic.run_asichas already provided a back-ward compatible to multi-asic and single-asic (https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/devices/sonic_asic.py#L404) we can leverage this API to execute the test.The test is also working with single-asic since in our system, single-asic chassis will have 1 asic with
namespace=Noneandasic-index=0How did you verify/test it?
Verified on T2 device and T0 kms
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation