Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround python_sai_thrift path issue #14886

Conversation

bingwang-ms
Copy link
Collaborator

Description of PR

Summary:
This PR is to workaround issue opencomputeproject/SAI#2086
The python_sai_thrift library is not installed to the right directory, which leads to qos_sai test failure.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

This PR is to workaround python_sai_thrift path issue.

How did you do it?

Copy switch_sai_thrift folder from saithrift-0.9-py3.11.egg to the parent folder.

How did you verify/test it?

The change is verified by running test_update_saithrift_ptf.

collected 1 item                                                                                                                                                                                      

test_pretest.py::test_update_saithrift_ptf PASSED                                                                                                                                               [100%]

Test is passing and the Python library is installed to the right directory.

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

Not a new test case.

Documentation

@bingwang-ms bingwang-ms merged commit d47e6de into sonic-net:master Oct 10, 2024
15 of 17 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Oct 10, 2024
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #14931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants