Add test_gnoi_system.py with a simple test for System.Time. #16334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
tests/gnmi/test_gnoi_system.py:27
- The error message could be more descriptive. Suggested change: 'System.Time API call failed with return code {} and message: {}'.format(ret, msg)
pytest_assert(ret == 0, "System.Time API unexpectedly reported failure")
tests/gnmi/test_gnoi_system.py:19
- The comment is clear and correctly formatted.
"""
Verify the gNOI System Time API returns the current system time in valid JSON format.
"""
ganglyu
approved these changes
Jan 6, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xincunli-sonic
approved these changes
Jan 7, 2025
qiluo-msft
previously approved these changes
Jan 10, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
ganglyu
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Create a new file for testing GNOI System API and bootstrap it with a simple test for System.Time
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Create a new file for testing GNOI System API and bootstrap it with a simple test for System.Time
How did you do it?
Create a new file for testing GNOI System API and bootstrap it with a simple test for System.Time
How did you verify/test it?
Run on KVM
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation