Skip to content

fix(tests): add backplane port only in srv6 tests #16669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

LARLSN
Copy link
Contributor

@LARLSN LARLSN commented Jan 24, 2025

Description of PR

update to configure the backplane port only in the srv6 test.
fix #16585

Summary:
Fixes #16585

Type of change

  • [X ] Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Backplane port is necessary in our srv6 tests, but it will cause random failure in other tests. When the test packet dst IP matches the IP prefix advertised by the exabgp, the ptf backplane interface will receive the test packet from the neighbor VM. The reason is the routes are advertised by exabgp to VM through the ptf backplane interface. And methods like verify_packet_any_port() not only validate the packet is received by the expected ports, but also validate it's not received by the unexpected ports.

How did you do it?

Added configuration options in ptf initial to limite the configuration scenarios of backplane ports only in srv6 tests

How did you verify/test it?

we tested it via daily jenkins run
image
image

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rajneeshaec
Copy link
Contributor

Same fix is also applicable in 202411 branch

@StormLiangMS
Copy link
Collaborator

/azp run Azure.sonic-mgmt

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StormLiangMS
Copy link
Collaborator

hi @LARLSN could you check the pre test SA failure?
image

@LARLSN
Copy link
Contributor Author

LARLSN commented Feb 8, 2025

hi @LARLSN could you check the pre test SA failure? image

ok, let me check it

Signed-off-by: linsongnan <linsongnan.lsn@alibaba-inc.com>
@LARLSN LARLSN force-pushed the dev-lsn-fix-ptfadapter branch from 51f6160 to 996eb7d Compare February 8, 2025 08:41
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LARLSN
Copy link
Contributor Author

LARLSN commented Feb 8, 2025

hi @LARLSN could you check the pre test SA failure? image

i've resolved it and Pre_test Static Analysis seems successful

@wangxin wangxin merged commit a485466 into sonic-net:master Feb 11, 2025
17 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Feb 11, 2025
What is the motivation for this PR?
Backplane port is necessary in our srv6 tests, but it will cause random failure in other tests. When the test packet dst IP matches the IP prefix advertised by the exabgp, the ptf backplane interface will receive the test packet from the neighbor VM. The reason is the routes are advertised by exabgp to VM through the ptf backplane interface. And methods like verify_packet_any_port() not only validate the packet is received by the expected ports, but also validate it's not received by the unexpected ports.

How did you do it?
Added configuration options in ptf initial to limite the configuration scenarios of backplane ports only in srv6 tests

How did you verify/test it?
we tested it via daily jenkins run

Signed-off-by: linsongnan <linsongnan.lsn@alibaba-inc.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #16902

mssonicbld pushed a commit that referenced this pull request Feb 12, 2025
What is the motivation for this PR?
Backplane port is necessary in our srv6 tests, but it will cause random failure in other tests. When the test packet dst IP matches the IP prefix advertised by the exabgp, the ptf backplane interface will receive the test packet from the neighbor VM. The reason is the routes are advertised by exabgp to VM through the ptf backplane interface. And methods like verify_packet_any_port() not only validate the packet is received by the expected ports, but also validate it's not received by the unexpected ports.

How did you do it?
Added configuration options in ptf initial to limite the configuration scenarios of backplane ports only in srv6 tests

How did you verify/test it?
we tested it via daily jenkins run

Signed-off-by: linsongnan <linsongnan.lsn@alibaba-inc.com>
nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request Mar 15, 2025
What is the motivation for this PR?
Backplane port is necessary in our srv6 tests, but it will cause random failure in other tests. When the test packet dst IP matches the IP prefix advertised by the exabgp, the ptf backplane interface will receive the test packet from the neighbor VM. The reason is the routes are advertised by exabgp to VM through the ptf backplane interface. And methods like verify_packet_any_port() not only validate the packet is received by the expected ports, but also validate it's not received by the unexpected ports.

How did you do it?
Added configuration options in ptf initial to limite the configuration scenarios of backplane ports only in srv6 tests

How did you verify/test it?
we tested it via daily jenkins run

Signed-off-by: linsongnan <linsongnan.lsn@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Random ptf verify packet failures caused by PR#15349
6 participants