Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:16854] Add memory consumption check for bgpd/openbmpd during test_default_route_with_bgp_flap stress test #16859

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

Summary:
Microsoft ADO id: 27588923
Added performance test for bmp feature, since after bmp feature switch is enabled it will introduce some impact into below two processes:
/usr/lib/frr/bgpd -A 127.0.0.1 -P 0 -M snmp -M bmp
/usr/bin/openbmpd -f -l /var/log/openbmpd.log -c /etc/bmp/openbmpd.conf

This PR aims at adding some memory monitoring measurement during test_default_route_with_bgp_flap() execution, given this case will introduce bgp flapping which is under extreme condition, and impact bgpd/openbmpd potentially.

Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Add some memory monitoring measurement during test_default_route_with_bgp_flap() execution, given this case will introduce bgp flapping which is under extreme condition, and impact bgpd/openbmpd potentially.

How did you do it?

Before test_default_route_with_bgp_flap() is launched, it will record current memory utilization of bgpd/openbmpd as initial value, during the bgp flapping test execution, there'll be two dedicated threads which check memory utilization every 30s and see if it exceeds two times of initial value and break the test correspondingly.

How did you verify/test it?

image

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

…ute_with_bgp_flap stress test (sonic-net#16854)

Description of PR
Summary:
Added performance test for bmp feature, since after bmp feature switch is enabled it will introduce some impact into below two processes:
/usr/lib/frr/bgpd -A 127.0.0.1 -P 0 -M snmp -M bmp
/usr/bin/openbmpd -f -l /var/log/openbmpd.log -c /etc/bmp/openbmpd.conf

This PR aims at adding some memory monitoring measurement during test_default_route_with_bgp_flap() execution, given this case will introduce bgp flapping which is under extreme condition, and impact bgpd/openbmpd potentially.

Approach
What is the motivation for this PR?
Add some memory monitoring measurement during test_default_route_with_bgp_flap() execution, given this case will introduce bgp flapping which is under extreme condition, and impact bgpd/openbmpd potentially.

How did you do it?
Before test_default_route_with_bgp_flap() is launched, it will record current memory utilization of bgpd/openbmpd as initial value, during the bgp flapping test execution, there'll be two dedicated threads which check memory utilization every 30s and see if it exceeds two times of initial value and break the test correspondingly.
@mssonicbld
Copy link
Collaborator Author

/azp run

@mssonicbld
Copy link
Collaborator Author

Original PR: #16854

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 76c917f into sonic-net:202411 Feb 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants