Skip to content

[t0 t1 test merge] migrate ECN multidiut #16866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

auspham
Copy link
Contributor

@auspham auspham commented Feb 10, 2025

Description of PR

Summary:

As part of test merge plan, we're merging tests/snappi_tests/multidut to tests/snappi_tests for ECN folder.

This PR simply moving over the same code in tests/snappi_tests/multidut/ecn to tests/snappi_tests/ecn as it and resolve a few conflicts.

Fixes # (issue) 31217327

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Described above.

How did you do it?

  1. All the tests in tests/snappi_tests/multidut/ecn folder are ran nightly on t0 to verify the status
  2. Compare each file in tests/snappi_tests/multidut/ecn folder with tests/snappi_tests/ecn folder to find the differences
  3. Resolve the differences and modify so that it fits with t0 platform
  4. Ran regression on t0 platforms and verify if it works

How did you verify/test it?

We run regression on T0 platform and T2 platforms to verify if this works. Verification includes 2 main process

  1. Nightly verification trigger on before-merge branch multidut for regression
  2. Verification trigger on original tests/snappi_tests/ecn folder for baseline comparison
  3. Verification trigger on after-merge branch to compare new process. Only failures existed in baseline are acceptable.
     

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/31217327-merge-multidut-ecn branch from ffd7fba to f1dfbc7 Compare February 10, 2025 01:17
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/31217327-merge-multidut-ecn branch from f1dfbc7 to cb84bde Compare February 10, 2025 06:47
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/31217327-merge-multidut-ecn branch from cb84bde to 002097c Compare February 10, 2025 22:54
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang
Copy link
Contributor

T0 test result: MSFT access only

@sdszhang
Copy link
Contributor

@auspham auspham force-pushed the austinpham/31217327-merge-multidut-ecn branch from 002097c to 70f5af7 Compare February 13, 2025 00:34
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

executor.submit(config_reload, duthost, wait_before_force_reload=300, safe_reload=True,
check_intf_up_ports=True, wait_for_bgp=True)
check_intf_up_ports=True, wait_for_bgp=wait_for_bgp)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In here we dont want to wait_for_bgp if we specified that we skip sanity.

@auspham
Copy link
Contributor Author

auspham commented Feb 13, 2025

MSFT only tests: https://elastictest.org/scheduler/testplan/67ad53046f7ee067ea75ff08

I also find that the failure cases also fail in legacy code.

Signed-off-by: Austin Pham <austinpham@microsoft.com>
@auspham auspham force-pushed the austinpham/31217327-merge-multidut-ecn branch from 70f5af7 to dbe7cfe Compare February 13, 2025 11:03
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 3b6d6d1 into sonic-net:master Feb 25, 2025
19 checks passed
@mssonicbld
Copy link
Collaborator

@auspham PR conflicts with 202411 branch

yejianquan pushed a commit that referenced this pull request Feb 25, 2025
Description of PR
Summary: Address conflict for #16866
Fixes # (issue)

Signed-off-by: Austin Pham <austinpham@microsoft.com>
nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Mar 4, 2025
Description of PR
Summary:

As part of test merge plan, we're merging tests/snappi_tests/multidut to tests/snappi_tests for ECN folder.

This PR simply moving over the same code in tests/snappi_tests/multidut/ecn to tests/snappi_tests/ecn as it and resolve a few conflicts.

Fixes # (issue) 31217327

Approach
What is the motivation for this PR?
Described above.

How did you do it?
All the tests in tests/snappi_tests/multidut/ecn folder are ran nightly on t0 to verify the status
Compare each file in tests/snappi_tests/multidut/ecn folder with tests/snappi_tests/ecn folder to find the differences
Resolve the differences and modify so that it fits with t0 platform
Ran regression on t0 platforms and verify if it works
How did you verify/test it?
We run regression on T0 platform and T2 platforms to verify if this works. Verification includes 2 main process

Nightly verification trigger on before-merge branch multidut for regression
Verification trigger on original tests/snappi_tests/ecn folder for baseline comparison
Verification trigger on after-merge branch to compare new process. Only failures existed in baseline are acceptable.

Signed-off-by: Austin Pham <austinpham@microsoft.com>
nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request Mar 15, 2025
Description of PR
Summary:

As part of test merge plan, we're merging tests/snappi_tests/multidut to tests/snappi_tests for ECN folder.

This PR simply moving over the same code in tests/snappi_tests/multidut/ecn to tests/snappi_tests/ecn as it and resolve a few conflicts.

Fixes # (issue) 31217327

Approach
What is the motivation for this PR?
Described above.

How did you do it?
All the tests in tests/snappi_tests/multidut/ecn folder are ran nightly on t0 to verify the status
Compare each file in tests/snappi_tests/multidut/ecn folder with tests/snappi_tests/ecn folder to find the differences
Resolve the differences and modify so that it fits with t0 platform
Ran regression on t0 platforms and verify if it works
How did you verify/test it?
We run regression on T0 platform and T2 platforms to verify if this works. Verification includes 2 main process

Nightly verification trigger on before-merge branch multidut for regression
Verification trigger on original tests/snappi_tests/ecn folder for baseline comparison
Verification trigger on after-merge branch to compare new process. Only failures existed in baseline are acceptable.

Signed-off-by: Austin Pham <austinpham@microsoft.com>
zhixzhu pushed a commit to zhixzhu/sonic-mgmt that referenced this pull request May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants