-
Notifications
You must be signed in to change notification settings - Fork 871
[t0 t1 test merge] migrate ECN multidiut #16866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[t0 t1 test merge] migrate ECN multidiut #16866
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
ffd7fba
to
f1dfbc7
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
f1dfbc7
to
cb84bde
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
cb84bde
to
002097c
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
T0 test result: MSFT access only |
002097c
to
70f5af7
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
tests/conftest.py
Outdated
executor.submit(config_reload, duthost, wait_before_force_reload=300, safe_reload=True, | ||
check_intf_up_ports=True, wait_for_bgp=True) | ||
check_intf_up_ports=True, wait_for_bgp=wait_for_bgp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In here we dont want to wait_for_bgp if we specified that we skip sanity.
MSFT only tests: https://elastictest.org/scheduler/testplan/67ad53046f7ee067ea75ff08 I also find that the failure cases also fail in legacy code. |
Signed-off-by: Austin Pham <austinpham@microsoft.com>
70f5af7
to
dbe7cfe
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@auspham PR conflicts with 202411 branch |
Description of PR Summary: Address conflict for #16866 Fixes # (issue) Signed-off-by: Austin Pham <austinpham@microsoft.com>
Description of PR Summary: As part of test merge plan, we're merging tests/snappi_tests/multidut to tests/snappi_tests for ECN folder. This PR simply moving over the same code in tests/snappi_tests/multidut/ecn to tests/snappi_tests/ecn as it and resolve a few conflicts. Fixes # (issue) 31217327 Approach What is the motivation for this PR? Described above. How did you do it? All the tests in tests/snappi_tests/multidut/ecn folder are ran nightly on t0 to verify the status Compare each file in tests/snappi_tests/multidut/ecn folder with tests/snappi_tests/ecn folder to find the differences Resolve the differences and modify so that it fits with t0 platform Ran regression on t0 platforms and verify if it works How did you verify/test it? We run regression on T0 platform and T2 platforms to verify if this works. Verification includes 2 main process Nightly verification trigger on before-merge branch multidut for regression Verification trigger on original tests/snappi_tests/ecn folder for baseline comparison Verification trigger on after-merge branch to compare new process. Only failures existed in baseline are acceptable. Signed-off-by: Austin Pham <austinpham@microsoft.com>
Description of PR Summary: As part of test merge plan, we're merging tests/snappi_tests/multidut to tests/snappi_tests for ECN folder. This PR simply moving over the same code in tests/snappi_tests/multidut/ecn to tests/snappi_tests/ecn as it and resolve a few conflicts. Fixes # (issue) 31217327 Approach What is the motivation for this PR? Described above. How did you do it? All the tests in tests/snappi_tests/multidut/ecn folder are ran nightly on t0 to verify the status Compare each file in tests/snappi_tests/multidut/ecn folder with tests/snappi_tests/ecn folder to find the differences Resolve the differences and modify so that it fits with t0 platform Ran regression on t0 platforms and verify if it works How did you verify/test it? We run regression on T0 platform and T2 platforms to verify if this works. Verification includes 2 main process Nightly verification trigger on before-merge branch multidut for regression Verification trigger on original tests/snappi_tests/ecn folder for baseline comparison Verification trigger on after-merge branch to compare new process. Only failures existed in baseline are acceptable. Signed-off-by: Austin Pham <austinpham@microsoft.com>
…/16866-fix Fixes # (issue) sonic-net#16866 cherrypick https://github.com/sonic-net/sonic-mgmt/pull/16866/commits
Description of PR
Summary:
As part of test merge plan, we're merging tests/snappi_tests/multidut to tests/snappi_tests for ECN folder.
This PR simply moving over the same code in tests/snappi_tests/multidut/ecn to tests/snappi_tests/ecn as it and resolve a few conflicts.
Fixes # (issue) 31217327
Type of change
Back port request
Approach
What is the motivation for this PR?
Described above.
How did you do it?
How did you verify/test it?
We run regression on T0 platform and T2 platforms to verify if this works. Verification includes 2 main process
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation