make sure only syncd is match on pgrep #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure only syncd is match on pgrep
|
@yxieca Can you please review/approve. |
|
what is '-x' can you explain how you did it? |
Fix is to use -x option of pgrep to exact match on syncd. From man pgrep |
yxieca
approved these changes
May 30, 2020
yxieca
pushed a commit
that referenced
this pull request
Jun 2, 2020
make sure only syncd is match on pgrep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure only syncd is match on pgrep. Without this even /usr/bin/syncd.sh were getting O/P of pgrep command making test case case fail as we expect no O/P once syncd is terminated.
Fix for Issue sonic-net/sonic-buildimage#4127
Fix is to use -x option of pgrep to exact match on syncd.
-x, --exact
Only match processes whose names (or command line if -f is specified) exactly match the pattern.
Verified Manually syncd process gets terminated with no core.
also run testcase "restart_syncd"