Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the timeout value for check_bgp_session_state #17290

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

weiguo-nvidia
Copy link
Contributor

Description of PR

Summary: Add the timeout value for check_bgp_session_state
Fixes #
Test case test_bgp_session_interface_down[interface-swss_docker] failed due to BGP session not UP
Check the syslog, all BGP session are UP but takes more time. This is the time line

  1. Execute command docker restart swss at 2025-02-28 23:33:09.621050
  2. All critical processes are UP at 2025-02-28 23:35:53.413089 and then start to check BGP session status. Timeout value is 60s
  3. The first BGP session in Established status at 23:36:55.120466 and the last BGP session in Established status at 23:37:06.034725. So needs more time to check if All BGP sessions are UP
2025 Feb 28 23:36:55.120466 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor 10.0.0.61(Unknown) in vrf default Up
2025 Feb 28 23:36:55.121168 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor fc00::7a(Unknown) in vrf default Up
2025 Feb 28 23:37:02.282313 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor 10.0.0.71(Unknown) in vrf default Up
2025 Feb 28 23:37:03.873604 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor fc00::8e(Unknown) in vrf default Up
2025 Feb 28 23:37:03.974046 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor 10.0.0.69(Unknown) in vrf default Up
2025 Feb 28 23:37:03.978547 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor fc00::8a(Unknown) in vrf default Up
2025 Feb 28 23:37:04.388032 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor 10.0.0.63(Unknown) in vrf default Up
2025 Feb 28 23:37:04.393283 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor 10.0.0.57(Unknown) in vrf default Up
2025 Feb 28 23:37:04.404789 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor 10.0.0.59(Unknown) in vrf default Up
2025 Feb 28 23:37:04.474376 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor 10.0.0.67(Unknown) in vrf default Up
2025 Feb 28 23:37:04.576819 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor 10.0.0.65(Unknown) in vrf default Up
2025 Feb 28 23:37:04.617386 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor fc00::76(Unknown) in vrf default Up
2025 Feb 28 23:37:05.007761 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor fc00::72(Unknown) in vrf default Up
2025 Feb 28 23:37:05.243813 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor fc00::82(Unknown) in vrf default Up
2025 Feb 28 23:37:06.027792 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor fc00::86(Unknown) in vrf default Up
2025 Feb 28 23:37:06.034725 r-panther-23 INFO bgp#bgpd[48]: [N9HHH-F8H1M] %ADJCHANGE: neighbor fc00::7e(Unknown) in vrf default Up

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@wsycqyz wsycqyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lğtm

Copy link
Contributor

@wsycqyz wsycqyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lğtm

@bingwang-ms bingwang-ms merged commit 2781283 into sonic-net:master Mar 12, 2025
16 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Mar 12, 2025
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #17471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants