[install image] removing config_db.json with -f option #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a DUT has already have the target image installed, then there will be no /host/old_config/config_db.json afterward installing. Add -f option to ignore file not exists error. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
neethajohn
approved these changes
Jun 10, 2020
yxieca
added a commit
that referenced
this pull request
Jun 10, 2020
If a DUT has already have the target image installed, then there will be no /host/old_config/config_db.json afterward installing. Add -f option to ignore file not exists error. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Type of change
Approach
What is the motivation for this PR?
If a DUT has already have the target image installed, then there will be no host/old_config/config_db.json afterward installing. Add -f option to ignore file not exists error.
At a second look, the DUT must have experienced multiple failure to get to this point: it must have an image installed but never rebooted (otherwise /host/old_config would have been removed). And then installed with another image which is already installed, so that we have /host/old_config/minigraph.yml, but no /host/old_config/config_db.json.
Either way, ignoring this failure would be necessary.
Signed-off-by: Ying Xie ying.xie@microsoft.com
How did you verify/test it?
Run ansible playboot upgrade_sonic.yml specifying an image already installed on the DUT.