Fix PFC ansible testcase config error of poll time greater than detection/restoration time. #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is check pfc_wd poll_time <= pfc_wd_detection/restoration_time. So make sure in testscript before setting poll interval stop pfc wd if enable by default because default detection/restoration time can be < poll time interval making script failure.
neethajohn
approved these changes
Jun 22, 2020
|
@prsunny If you are running pfc based on internal-201811 t qualify 201911 image |
yxieca
pushed a commit
that referenced
this pull request
Jun 24, 2020
there is check pfc_wd poll_time <= pfc_wd_detection/restoration_time. So make sure in testscript before setting poll interval stop pfc wd if enable by default because default detection/restoration time can be < poll time interval making script failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
After this PR#sonic-net/sonic-utilities#838
there is check pfc_wd poll_time <= pfc_wd_detection/restoration_time.
So make sure in testscript before setting poll interval stop
pfc wd if enable by default because default detection/restoration time
can be < poll time interval making script failure.
Verify:
After making changes test-case config went fine and test passes.