Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dynamic buffer calc] Test cases for dynamic buffer calculation #1971

Merged
merged 9 commits into from
Jan 7, 2021
Merged

[Dynamic buffer calc] Test cases for dynamic buffer calculation #1971

merged 9 commits into from
Jan 7, 2021

Commits on Dec 15, 2020

  1. [Dynamic buffer calc] Regression test for dynamic buffer calculation

    1. Add test cases for dynamic buffer calculation
      - changing speed/cable length test
      - headroom override
      - additional lossless PG
      - exceeding the accumulative headroom size of a port
      - default buffer model
    2. Adjust qos test, fetching configuration from:
      - APPL_DB if there is buffer_model defined, this is the case in master
      - CONF_DB otherwise, for 201911
    3. Additional checking script to test whether the buffer model is as expected.
       This can be  used by warm-reboot
    
    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    Stephen Sun authored and stephenxs committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    4c98df2 View commit details
    Browse the repository at this point in the history
  2. Address comments:

    use pytest_assert and google style doc strings
    verify buffer profile and pool against ASIC_DB
    move hardcoded parameters to a predefined json file
    add comments to make it easy to understand
    
    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    8ee5033 View commit details
    Browse the repository at this point in the history
  3. Fix review comments

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    aa5c072 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. Fix a typo and remove unused code

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    b1ea1e9 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2020

  1. Fix a syntax error by replacing "has" with "have"

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    5bbf23a View commit details
    Browse the repository at this point in the history
  2. Use the capital letters at the beginning of the sentence.

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    6d7e3a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Don't make isBufferInApplDb a fixture.

    It's more convenent to leave it as a class member for users
    
    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    25b7e18 View commit details
    Browse the repository at this point in the history
  2. Fix review comments

    - Use capital letters for global variable names
    - Remove spaces between "=" in argument list
    
    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    6a0600c View commit details
    Browse the repository at this point in the history
  3. detect_DEFAULT_MTU => detect_default_mtu

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    bbbe22f View commit details
    Browse the repository at this point in the history