-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme of PFCWD reboot and restart tests #2359
base: master
Are you sure you want to change the base?
Readme of PFCWD reboot and restart tests #2359
Conversation
docs/pfcwd/README_PFCWD_Restart.md
Outdated
- [Background](#background) | ||
- [PFC storm detection](#pfc-storm-detection) | ||
- [PFC storm mitigation](#pfc-storm-mitigation) | ||
- [PFC storm restoration](#pfc-storm-restoration) | ||
- [PFC watchdog implementation](#pfc-watchdog-implementation) | ||
- [PFC watchdog commands on SONiC](#pfc-watchdog-commands-on-sonic) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These sections can be omitted. Please move all this to a general readme under the pfcwd folder since it is the same for all cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omitted the TOC from the readme.
|
||
## Experiment Steps | ||
|
||
1. Execute the test “PFCWD_Basic_All-to-all” test for only one priority (e.g., 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please describe what the test "pfcwd basic all to all" does. Without that info, it is unclear what is being covered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a link to the testcase in this document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PFC WD Test Plan is yet to merge in sonic-mgmt/master - is it ok to provide the link of PR ( #2205 ) in actual document.
- [Background](#background) | ||
- [PFC storm detection](#pfc-storm-detection) | ||
- [PFC storm mitigation](#pfc-storm-mitigation) | ||
- [PFC storm restoration](#pfc-storm-restoration) | ||
- [PFC watchdog implementation](#pfc-watchdog-implementation) | ||
- [PFC watchdog commands on SONiC](#pfc-watchdog-commands-on-sonic) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move these sections to a general readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omitted the TOC section from readme
<code>$sudo warm-reboot [options] </code> | ||
|
||
2. Wait for the DUT to come up | ||
3. Execute the test "PFCWD\_Basic\_All-to-all" test for only one priority (e.g., 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain what is the pfcwd basic all to all test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a link to the testcase in this document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PFC WD Test Plan is yet to merge in sonic-mgmt/master - is it ok to provide the link of PR ( #2205 ) in actual document ?
@neethajohn did author addressed all your questions? |
Summary:
Readme of PFCWD reboot and restart tests.
Type of change