Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kvm/docs] Improve KVM setup instructions #2476

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Conversation

daall
Copy link
Contributor

@daall daall commented Nov 6, 2020

Signed-off-by: Danny Allen daall@microsoft.com

Description of PR

Summary: Improve KVM setup instructions
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

I received some feedback while helping people onboard to the KVM testbed:

  1. Not all VMs have ethtool installed by default, which can cause some strange errors.
  2. There was some confusion over how to access sonic-mgmt inside the docker container.
  3. Certain VM configurations (namely Hyper-V) require nested virtualization to be enabled explicitly in order to run KVM VMs inside them.
  4. It's not clear how to check if the tests/testbed is working after all of these setup steps are complete.

How did you do it?

  1. Added ethtool to the setup script.
  2. Added clarification for the mount point for sonic-mgmt.
  3. Added an explicit mention of nested virt.
  4. Added a step to run the bgp_fact test.

How did you verify/test it?

Verified that the setup scripts work as described, and are idempotent.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Danny Allen <daall@microsoft.com>
@daall daall requested review from lguohan, yxieca and pra-moh November 6, 2020 02:03
@lguohan
Copy link
Contributor

lguohan commented Nov 6, 2020

retest this please

echo

echo "STEP 5: Checking if bridge br1 already exists..."
if ! brctl show br1; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it returns the output as below, then this step fails. May be we should just add br1 even if it exists..

STEP 5: Checking if bridge br1 already exists...
bridge name	bridge id		STP enabled	interfaces
br1		can't get info No such device

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants