Move location of template file used by test_bgp_speaker #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template file tests/bgp_speaker/bgp_speaker_route.j2 is only used by script tests/bgp/test_bgp_speaker.py. What's more, it is also the only file under folder tests/bgp_speaker. It would be better to put test scripts and their dependent template files together. This change moves file tests/bgp_speaker/bgp_speaker_route.j2 to tests/bgp/templates. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
lguohan
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Move location of template file used by
tests/bgp/test_bgp_speaker.pyfromtests/bgp_speaker/totests/bgp/templates.Type of change
Approach
What is the motivation for this PR?
Template file tests/bgp_speaker/bgp_speaker_route.j2 is only used by
script tests/bgp/test_bgp_speaker.py. What's more, it is also the only
file under folder tests/bgp_speaker. It would be better to put test scripts
and their dependent template files together.
How did you do it?
This change moves file tests/bgp_speaker/bgp_speaker_route.j2 to tests/bgp/templates.
How did you verify/test it?
Test run
tests/bgp/test_bgp_speaker.py, all the cases passed.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation