Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[veos_vtb] Add connection variable to 'sonic' group #2639

Merged
merged 1 commit into from
Dec 15, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ansible/veos_vtb
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ all:
sonic:
vars:
mgmt_subnet_mask_length: 24
ansible_connection: multi_passwd_ssh
ansible_altpassword: YourPaSsWoRd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the multi_passwd_ssh is not accessible if tests/veos_vtb is selected as the inventory file. I think a fundamental problem is that the whole ansible/group_vars directory is not accessible when using tests/veos_vtb as the inventory file. I am not sure if any other things in ansible/group_vars are useful (or potentially useful) in pytest? If so, it is probably better to help pytest finding the directory (maybe a symbolic link)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like ansible always looks for group_vars and host_vars under the same directory of inventory file. Probably we can try:

cd tests
pytest -i ../ansible/veos_vtb ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but this is not the case in our public Jenkins vtestbed jobs, which uses the symbolic link under tests/.

hosts:
vlab-01:
ansible_host: 10.250.0.101
Expand Down