Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multi-dut] Support for gen-mg to work with multi-dut where VM's connect to only a single host and supervisor card #2700

Merged
merged 4 commits into from
Feb 8, 2021
Merged

[multi-dut] Support for gen-mg to work with multi-dut where VM's connect to only a single host and supervisor card #2700

merged 4 commits into from
Feb 8, 2021

Commits on Feb 5, 2021

  1. Support for gen-mg to work with multi-dut where VM's connect to only … 

    …a single host; support for supervisor card.

gen-mg supported multi-dut, but in a dualtor topology, each VM is assumed to
be connected to all the DUT's. To support the VM to be connected to a single DUT:
 - In vm_topo_config, the fields like interface_indexes, intfs, ip_intf etc would be
   either empty or null. Add checks for these where they are being used in gen-mg

gen-mg also assumes that all interfaces connected to a PortChannel are sequential. To fix this:
 - In config_sonic_based_on_testbed.yml, changed interface_to_vms structure to be compatable to
   allow using with_subelements to get the intf_names

For 'supervisor' card, there are no BGP peers, interfaces etc. required.
 - A 'supervisor' card is identified by having 'type' field in the inventory with value 'supervisor'.
 - Add this check to skip generation of portions not valid for supervisor card
    @sanmalho-git
    sanmalho-git committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    ef8c747 View commit details
    Browse the repository at this point in the history

  2. Minor fix

    @sanmalho-git
    sanmalho-git committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    e33501c View commit details
    Browse the repository at this point in the history

  3. Added comments to topo_facts as per review

    @sanmalho-git
    sanmalho-git committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    b665199 View commit details
    Browse the repository at this point in the history

  4. Remove a check that is not requied in config_sonic_basedon_testbed.ym… 

    …l based on review comment
    @sanmalho-git
    sanmalho-git committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    933c5cc View commit details
    Browse the repository at this point in the history