-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inner packet hashing community test #3320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anish-n
changed the title
Test inner packet hashing
Inner packet hashing community test
Apr 13, 2021
This pull request introduces 2 alerts when merging 87e46e8 into da9aed4 - view on LGTM.com new alerts:
|
Hi @nazariig requesting your review on this PR, thanks! |
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
nazariig
reviewed
Apr 15, 2021
This pull request introduces 2 alerts when merging eb04be6 into a7d70fe - view on LGTM.com new alerts:
|
yxieca
reviewed
Jul 15, 2021
yxieca
reviewed
Jul 15, 2021
yxieca
approved these changes
Jul 16, 2021
nazariig
approved these changes
Jul 19, 2021
@anish-n I noticed that the test cases were consistently failing in our nightly test. Is it because the setup is missing?
|
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Description of PR Introduces a test similar to the hash_test in SONiC, but for hashing based on the inner packet tuples. The test validates that packets are ECMP'd across multiple nexthops in an balanced way using the inner tuples only. Summary: Approach What is the motivation for this PR? To test packet hashing based on the inner packet tuples instead of the standard outer packet tuples. The test checks the distribution of packets is as expected, and that each of the inner packet hash parameters(inner src ip, dst ip, src port, dst port and ip proto) leads to a variation of ports hashed to, ie: ECMP spreading. The test also validates, as an optional mode, symmetric hashing: 2 directions of a flow end up on the same next-hop. Note: The test assumes that inner hashing is configured on DUT prior to the test, in the future once inner hashing becomes a configuration parameter via config db, the test will be enhanced with configuration abilities. Feature which will expose this via configuration: sonic-net/SONiC#773 How did you do it? PTF test which generates inner packet tuples How did you verify/test it? Developed the test and ran it on a DUT configured with inner hashing Any platform specific information? Supported on select Mellanox DUTs for now, other platforms may be added as they are tested Supported testbed topology if it's a new test case? T0 Other topologies may be added as they are tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Introduces a test similar to the hash_test in SONiC, but for hashing based on the inner packet tuples. The test validates that packets are ECMP'd across multiple nexthops in an balanced way using the inner tuples only.
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
To test packet hashing based on the inner packet tuples instead of the standard outer packet tuples. The test checks the distribution of packets is as expected, and that each of the inner packet hash parameters(inner src ip, dst ip, src port, dst port and ip proto) leads to a variation of ports hashed to, ie: ECMP spreading. The test also validates, as an optional mode, symmetric hashing: 2 directions of a flow end up on the same next-hop.
Note: The test assumes that inner hashing is configured on DUT prior to the test, in the future once inner hashing becomes a configuration parameter via config db, the test will be enhanced with configuration abilities. Feature which will expose this via configuration: sonic-net/SONiC#773
How did you do it?
PTF test which generates inner packet tuples
How did you verify/test it?
Developed the test and ran it on a DUT configured with inner hashing
Any platform specific information?
Supported on select Mellanox DUTs for now, other platforms may be added as they are tested
Supported testbed topology if it's a new test case?
T0
Other topologies may be added as they are tested.
Documentation
Test Plan: sonic-net/SONiC#759
Inner hashing feature configuration: sonic-net/SONiC#773