[Mellanox] Modify AbnormalFanMocker check_result return value #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return True if the actual fan data is same with the mock data, else return False.
nhe-NV
changed the title
nhe-NV
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Modify AbnormalFanMocker check_result return value
Fixes # (issue) Modify AbnormalFanMocker check_result return value to make test case "test_thermal_control_fan_status" pass
Type of change
Back port request
Approach
What is the motivation for this PR?
The test case "test_thermal_control_fan_status" will failed after the PR #3684 is merged
How did you do it?
Change the return value of the check_result in AbnormalFanMocker, before the #3684 is merged, it dose not care about the return value of the check_result in AbnormalFanMocker, after the PR is merged, it will check the return value of the check_result
How did you verify/test it?
Run test cases in test_platform_info.py and all the test cases pass
Any platform specific information?
No, it happens on any kind of platform