test_ro_disk: Save logs before making disk read-only #4432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2) Added to kvm tests
1) Use skip_release from common 2) Wait until instead of blind sleep
…opped 2) If reboot command may fail, retry 3) Wait for ssh port to be started and give a time for stabilizing
yxieca
reviewed
Oct 6, 2021
|
This pull request fixes 1 alert when merging cba4710 into 3d07729 - view on LGTM.com fixed alerts:
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Oct 11, 2021
renukamanavalan
added a commit
to renukamanavalan/sonic-mgmt
that referenced
this pull request
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The logs recorded in DUT during the test are completely lost. If you need to analyze a test run, via syslogs in DUT, it would not be easy to locate the time point of the test (as the timestamp in logs/test.log & in DUT's syslog could differ).
How did you do it?
Remove loganalyzer-disable
Flush the rsyslog (close & re-open all files) and force a log rotate, before making disk RO
How did you verify/test it?
Now you could see the loganalyzer marker and the logs from test, until the point of making disk RO.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation