Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reclaiming buffer] Test cases for reclaiming buffer on both traditional and dynamic model #4561

Merged
merged 29 commits into from
Dec 15, 2021

Conversation

stephenxs
Copy link
Contributor

@stephenxs stephenxs commented Oct 26, 2021

Description of PR

Summary: Test cases for reclaiming buffer on both traditional and dynamic model

It depends on all other PRs for reclaiming buffer

Signed-off-by: Stephen Sun stephens@nvidia.com

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

Add regression test cases of reclaiming buffer for both traditional and dynamic model

How did you do it?

  1. Adjust dynamic buffer test cases to verify reclaiming buffer in port admin down test
  2. Add deployment test to verify correct profiles in APPL_DB, and ASIC_DB have been applied on each port.
    This is for both traditional and dynamic buffer models.
  3. Adjust the script which transmits a switch from traditional model to dynamic model.
  4. Shut down BGP neighbors before test and start up them during teardown as we need to run the test in topologies other than ptf32.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

stephenxs and others added 25 commits September 17, 2021 10:26
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
…is defined

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
…e-dynamic-buffer.py

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
…he reference

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs requested a review from a team as a code owner October 26, 2021 08:18
@lgtm-com
Copy link

lgtm-com bot commented Oct 26, 2021

This pull request introduces 1 alert when merging 3959906 into 001c934 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Nov 1, 2021

This pull request introduces 1 alert when merging 8852a69 into 4f52b35 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Nov 16, 2021

This pull request introduces 1 alert when merging 8d8b5b3 into 46ef49d - view on LGTM.com

new alerts:

  • 1 for Unused local variable

stephenxs and others added 2 commits November 16, 2021 22:11
@liat-grozovik
Copy link
Collaborator

@stephenxs could you please refer which is the PR that this test depends on? For 201911 do we need a seperate PR or this can be cherry picked?
@neethajohn could you please help to review?

@stephenxs
Copy link
Contributor Author

@stephenxs could you please refer which is the PR that this test depends on? For 201911 do we need a seperate PR or this can be cherry picked?
@neethajohn could you please help to review?

This is for 202012 and above. For 201911 we already have a or which has been merged.

@qiluo-msft qiluo-msft merged commit 2b361e9 into sonic-net:master Dec 15, 2021
@stephenxs stephenxs deleted the reclaim-buffer-master-github branch December 15, 2021 09:08
AntonHryshchuk pushed a commit to AntonHryshchuk/sonic-mgmt that referenced this pull request Jan 4, 2022
…nal and dynamic model (sonic-net#4561)

### Description of PR

Summary: Test cases for reclaiming buffer on both traditional and dynamic model

### Approach
#### What is the motivation for this PR?
Add regression test cases of reclaiming buffer for both traditional and dynamic model

#### How did you do it?
1. Adjust dynamic buffer test cases to verify reclaiming buffer in port admin down test
2. Add deployment test to verify correct profiles in `APPL_DB`, and `ASIC_DB` have been applied on each port.
    This is for both traditional and dynamic buffer models.
3. Adjust the script which transmits a switch from traditional model to dynamic model.
4. Shut down BGP neighbors before test and start up them during teardown as we need to run the test in topologies other than `ptf32`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants