-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update location of gnxi files in test_telemetry due to docker-ptf modification #5574
Conversation
Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
This change is not required for 202012 branch. For 202012 image, we are using PTF docker image built from 202012 branch. That PTF docker does not have change sonic-net/sonic-buildimage#10599. |
@wenyiz2021 I guess the testbed was deployed using master branch. Then if you switch to 202012 and run this test, it will fail.
This command will re-create the PTF docker using image with tag I am not going to cherry-pick this change to 202012 because our 202012 nightly tests were using 202012 PTF docker. Cherry-pick this will break our nightly test for 2022012. @ZhaohuiS Can you improve this test to check location of the gnxi files under both |
Thanks Xin. It would be good if we get gnxi files under both dir, ow AZP run will fail on 202012. |
Submitted a new PR #5634 to fix it. |
What is the motivation for this PR? PR sonic-net/sonic-buildimage#10599 move the work directory to /root. So gnxi is moved to /root. test_telemetry failed because of wrong file location. How did you do it? Update /gnxi/... to /root/gnxi/... How did you verify/test it? run tests/telemetry/test_telemetry.py Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
Description of PR
Summary:
Fixes # (issue)
Update location of gnxi files due to docker-ptf modification
Signed-off-by: Zhaohui Sun zhaohuisun@microsoft.com
Type of change
Back port request
Approach
What is the motivation for this PR?
PR sonic-net/sonic-buildimage#10599 move the work directory to /root.
So gnxi is moved to /root. test_telemetry failed because of wrong file location.
How did you do it?
Update
/gnxi/...
to/root/gnxi/...
How did you verify/test it?
run
tests/telemetry/test_telemetry.py
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation