[pfcwd] For zero buffer pfcwd detection logic, verify forward action on Rx

[neethajohn]

Signed-off-by: Neetha John nejo@microsoft.com

Description of PR

For platforms that use the zero buffer detection logic for pfcwd, modify the testcase to check for ingress traffic getting forwarded. Related to sonic-net/sonic-swss#2279

Summary:
Fixes # (issue)

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Back port request

• 201911
• 202012

How did you verify/test it?

Ran the test with these changes on Mellanox platform and it passed

[vivekrnv]

Hi @neethajohn,

Looks like the test_pfcwd_warm_reboot.py has to be updated as well with the new drop actions on ingress.

pfcwd/test_pfcwd_warm_reboot.py::TestPfcwdWb::test_pfcwd_wb[no_storm] 
-------------------------------------------------------------------------------------------------------------- live log setup ---------------------------------------------------------------------------------------------------------------
15:15:16 INFO __init__.py:set_default:49: Completeness level not set during test execution. Setting to default level: CompletenessLevel.basic
15:15:16 INFO __init__.py:check_test_completeness:139: Test has no defined levels. Continue without test completeness checks
15:15:31 ERROR facts_cache.py:read:87: Load json file "/root/mars/workspace/sonic-mgmt/tests/_cache/arc-switch1004/basic_facts.json" failed with exception: IOError(2, 'No such file or directory')
15:15:36 INFO facts_cache.py:write:106: Create cache dir /root/mars/workspace/sonic-mgmt/tests/_cache/arc-switch1004
15:15:36 INFO facts_cache.py:write:112: Cached facts "arc-switch1004.basic_facts" under /root/mars/workspace/sonic-mgmt/tests/_cache/arc-switch1004
15:15:38 INFO ptfhost_utils.py:change_mac_addresses:86: Change interface MAC addresses on ptfhost 'ptf-1004'
15:15:40 INFO ptfhost_utils.py:copy_ptftests_directory:48: Copy PTF test files to PTF host 'ptf-1004'
15:16:05 INFO conftest.py:generate_params_dut_hostname:675: DUTs in testbed 'arc-switch1004-t0' are: ['arc-switch1004']
15:16:05 INFO conftest.py:creds:362: dut arc-switch1004 belongs to groups [u'lab', u'leaf_topo_1', u'sonic', u'sonic_latest', 'fanout']
15:16:05 INFO conftest.py:creds:374: skip empty var file ../ansible/group_vars/all/env.yml
15:16:05 INFO conftest.py:creds:374: skip empty var file ../ansible/group_vars/all/corefile_uploader.yml
15:16:08 INFO __init__.py:sanity_check:46: Start pre-test sanity check
15:16:08 INFO __init__.py:sanity_check:56: Found marker: m.name=disable_loganalyzer, m.args=(), m.kwargs={}
15:16:08 INFO __init__.py:sanity_check:56: Found marker: m.name=topology, m.args=('any',), m.kwargs={}
15:16:08 INFO __init__.py:sanity_check:90: Sanity check settings: skip_sanity=True, check_items=set(['monit', 'processes', 'interfaces', 'bgp', 'services', 'dbmemory']), allow_recover=True, recover_method=adaptive, post_check=False
15:16:08 INFO __init__.py:sanity_check:93: Skip sanity check according to command line argument or configuration of test script.
15:16:08 ERROR facts_cache.py:read:87: Load json file "/root/mars/workspace/sonic-mgmt/tests/_cache/arc-switch1004/mg_facts.json" failed with exception: IOError(2, 'No such file or directory')
15:16:09 INFO facts_cache.py:write:112: Cached facts "arc-switch1004.mg_facts" under /root/mars/workspace/sonic-mgmt/tests/_cache/arc-switch1004
15:16:14 INFO conftest.py:setup_pfc_test:101: --- Stopping Pfcwd ---
15:16:16 INFO __init__.py:loganalyzer:17: Log analyzer is disabled
15:16:16 INFO test_pfcwd_warm_reboot.py:setup_pfcwd:49: Setup the default pfcwd config for warm-reboot test
--------------------------------------------------------------------------------------------------------------- live log call ---------------------------------------------------------------------------------------------------------------
15:16:24 INFO test_pfcwd_warm_reboot.py:test_pfcwd_wb:547: --- Test PFC storm detect/restore before and after warm boot ---
15:16:24 INFO test_pfcwd_warm_reboot.py:pfcwd_wb_helper:486: 
15:16:24 INFO test_pfcwd_warm_reboot.py:pfcwd_wb_helper:487: --- Testing on Ethernet10 ---
15:16:24 INFO test_pfcwd_warm_reboot.py:setup_test_params:97: --- Setting up test params for port Ethernet10 ---
15:16:45 INFO test_pfcwd_warm_reboot.py:run_test:388: --- Storm detection path for port Ethernet10 queue 4 ---
15:16:52 INFO pfc_storm.py:start_storm:196: --- Starting PFC storm on arc-switch1005 on interfaces ethernet 1/3/2 on queue 4 ---
15:17:14 INFO test_pfcwd_warm_reboot.py:storm_detect_path:317: Verify if PFC storm is detected on port Ethernet10 queue 4
15:17:20 INFO test_pfcwd_warm_reboot.py:verify_wd_func:270: --- Verify PFCwd function for action drop ---
15:17:20 INFO test_pfcwd_warm_reboot.py:verify_tx_egress:216: Check for egress drop on Tx port Ethernet10
15:17:22 INFO test_pfcwd_warm_reboot.py:verify_rx_ingress:241: Check for ingress drop on Rx port Ethernet10






RunAnsibleModuleFail: run module shell failed, Ansible Results =>
E           {
E               "changed": true, 
E               "cmd": "ptf --test-dir ptftests pfc_wd.PfcWdTest --platform-dir ptftests --platform remote -t 'port_type='\"'\"'vlan'\"'\"';port_src=5;ip_dst=u'\"'\"'10.0.0.57'\"'\"';router_mac=u'\"'\"'ec:0d:9a:fa:c1:00'\"'\"';wd_action='\"'\"'drop'\"'\"';pkt_count=100;port_dst='\"'\"'[28]'\"'\"';queue_index=4' --relax --debug info --log-file /tmp/pfc_wd.PfcWdTest.2022-06-20-15:17:22.log", 
E               "delta": "0:00:00.941062", 
E               "end": "2022-06-20 15:17:23.132121", 
E               "failed": true, 
E               "invocation": {
E                   "module_args": {
E                       "_raw_params": "ptf --test-dir ptftests pfc_wd.PfcWdTest --platform-dir ptftests --platform remote -t 'port_type='\"'\"'vlan'\"'\"';port_src=5;ip_dst=u'\"'\"'10.0.0.57'\"'\"';router_mac=u'\"'\"'ec:0d:9a:fa:c1:00'\"'\"';wd_action='\"'\"'drop'\"'\"';pkt_count=100;port_dst='\"'\"'[28]'\"'\"';queue_index=4' --relax --debug info --log-file /tmp/pfc_wd.PfcWdTest.2022-06-20-15:17:22.log", 
E                       "_uses_shell": true, 
E                       "argv": null, 
E                       "chdir": "/root", 
E                       "creates": null, 
E                       "executable": null, 
E                       "removes": null, 
E                       "stdin": null, 
E                       "stdin_add_newline": true, 
E                       "strip_empty_ends": true, 
E                       "warn": true
E                   }
E               }, 
E               "msg": "non-zero return code", 
E               "rc": 1, 
E               "start": "2022-06-20 15:17:22.191059", 
E               "stderr": "/usr/local/lib/python2.7/dist-packages/paramiko/transport.py:33: CryptographyDeprecationWarning: Python 2 is no longer supported by the Python core team. Support for it is now deprecated in cryptography, and will be removed in the next release.\n  from cryptography.hazmat.backends import default_backend\npfc_wd.PfcWdTest ... FAIL\n\n======================================================================\nFAIL: pfc_wd.PfcWdTest\n----------------------------------------------------------------------\nTraceback (most recent call last):\n  File \"ptftests/pfc_wd.py\", line 113, in runTest\n    return verify_no_packet_any(self, masked_exp_pkt, dst_port_list)\n  File \"/usr/lib/python2.7/dist-packages/ptf/testutils.py\", line 2476, in verify_no_packet_any\n    verify_no_packet(test, pkt, (device, port))\n  File \"/usr/lib/python2.7/dist-packages/ptf/testutils.py\", line 2422, in verify_no_packet\n    \"port %r.\\n%s\" % (device, port, result.format()))\nAssertionError: Received packet that we expected not to receive on device 0, port 28.\n========== RECEIVED ==========\n0000   26 42 D5 7A 41 34 EC 0D  9A FA C1 00 08 00 45 11   &B.zA4........E.\n0010   00 56 00 01 00 00 3F 06  6F 56 01 01 01 01 0A 00   .V....?.oV......\n0020   00 39 49 E3 C3 98 00 00  00 00 00 00 00 00 50 02   .9I...........P.\n0030   20 00 79 EB 00 00 00 01  02 03 04 05 06 07 08 09    .y.............\n0040   0A 0B 0C 0D 0E 0F 10 11  12 13 14 15 16 17 18 19   ................\n0050   1A 1B 1C 1D 1E 1F 20 21  22 23 24 25 26 27 28 29   ...... !\"#$%&'()\n0060   2A 2B 2C 2D                                        *+,-\n==============================\n\n\n----------------------------------------------------------------------\nRan 1 test in 0.030s\n\nFAILED (failures=1)", 
E               "stderr_lines": [
E                   "/usr/local/lib/python2.7/dist-packages/paramiko/transport.py:33: CryptographyDeprecationWarning: Python 2 is no longer supported by the Python core team. Support for it is now deprecated in cryptography, and will be removed in the next release.", 
E                   "  from cryptography.hazmat.backends import default_backend", 
E                   "pfc_wd.PfcWdTest ... FAIL", 
E                   "", 
E                   "======================================================================", 
E                   "FAIL: pfc_wd.PfcWdTest", 
E                   "----------------------------------------------------------------------", 
E                   "Traceback (most recent call last):", 
E                   "  File \"ptftests/pfc_wd.py\", line 113, in runTest", 
E                   "    return verify_no_packet_any(self, masked_exp_pkt, dst_port_list)", 
E                   "  File \"/usr/lib/python2.7/dist-packages/ptf/testutils.py\", line 2476, in verify_no_packet_any", 
E                   "    verify_no_packet(test, pkt, (device, port))", 
E                   "  File \"/usr/lib/python2.7/dist-packages/ptf/testutils.py\", line 2422, in verify_no_packet", 
E                   "    \"port %r.\\n%s\" % (device, port, result.format()))", 
E                   "AssertionError: Received packet that we expected not to receive on device 0, port 28.", 
E                   "========== RECEIVED ==========", 
E                   "0000   26 42 D5 7A 41 34 EC 0D  9A FA C1 00 08 00 45 11   &B.zA4........E.", 
E                   "0010   00 56 00 01 00 00 3F 06  6F 56 01 01 01 01 0A 00   .V....?.oV......", 
E                   "0020   00 39 49 E3 C3 98 00 00  00 00 00 00 00 00 50 02   .9I...........P.", 
E                   "0030   20 00 79 EB 00 00 00 01  02 03 04 05 06 07 08 09    .y.............", 
E                   "0040   0A 0B 0C 0D 0E 0F 10 11  12 13 14 15 16 17 18 19   ................", 
E                   "0050   1A 1B 1C 1D 1E 1F 20 21  22 23 24 25 26 27 28 29   ...... !\"#$%&'()", 
E                   "0060   2A 2B 2C 2D                                        *+,-", 
E                   "==============================", 
E                   "", 
E                   "", 
E                   "----------------------------------------------------------------------", 
E                   "Ran 1 test in 0.030s", 
E                   "", 
E                   "FAILED (failures=1)"
E               ], 
E               "stdout": "", 
E               "stdout_lines": []

E }