Enable test_normal_op config reload Tests #6227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Issue should have been addressed in sonic-net/sonic-platform-daemons#287 |
zjswhhh
force-pushed
the
test_config_reload
branch
from
001f901
to
e4999e7
Compare
|
This pull request fixes 1 alert when merging e4999e7 into 4beaffb - view on LGTM.com fixed alerts:
|
lolyu
approved these changes
Sep 7, 2022
Azarack
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 17, 2022
Description of PR Summary: Fixes # (issue) This PR is to enable config reload tests for active-active ports. sign-off: Jing Zhang zhangjing@microsoft.com Type of change Test case(new/improvement) Approach What is the motivation for this PR? To cover more test scenario for active-active ports.
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
Description of PR Summary: Fixes # (issue) This PR is to enable config reload tests for active-active ports. sign-off: Jing Zhang zhangjing@microsoft.com Type of change Test case(new/improvement) Approach What is the motivation for this PR? To cover more test scenario for active-active ports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
This PR is to enable config reload tests for active-active ports.
sign-off: Jing Zhang zhangjing@microsoft.com
Type of change
Back port request
Approach
What is the motivation for this PR?
To cover more test scenario for active-active ports.
How did you do it?
1. Add option to config back toautofor toggle_ports, to avoid the time gap between toggle active and toggle auto introduced byyield. So when test happen, both ToRs should be inautomode.2. Add new fixturetoggle_auto_all_ports_both_tors.3. For upstream io, dest_mac is vlan mac, so before
switchPeerForwardingStatehappens, disruption is expected. Hence, added delay=MUX_SIM_ALLOWED_DISRUPTION_SEC.How did you verify/test it?
Existing tests for active-active that use
toggle_active_all_ports_both_torsall passed, no regression introduced.Config reload tests having consistent 133s disruption. Created issue: NIC simulator not receiving SetAdminForwardingPortState request for 2 min after peer config reload sonic-utilities#2485
Issue should have been addressed in [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic sonic-platform-daemons#287
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation