Add BGP Suppress FIB Pending test plan #7475
Conversation
Add BGP Suppress FIB Pending test plan Change-Id: I1be42ed1bcddf0ad7ea9c45a809a89583a6554dd
|
@StormLiangMS @prsunny could you please suggest who should review this test plan as well? |
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@StormLiangMS could you please help to review? |
| Also, in the following scenario, a credit loop occurs: | ||
| ###### Figure 1. Use case scenario | ||
|
|
||
|  |
There was a problem hiding this comment.
could we add stress and performance test?
- Stress, to announce and withdraw 1000 routes for 5 or 10 times, then check the routes consistency.
- performance, what's the delay we should expect here for like 1000 routes?
There was a problem hiding this comment.
For the stress test, we have case 4 to enable bgp-suppress-fib-pending function and run all the community bgp cases, it's including stress and consistency test. For performance test, we have another team to cover it.
There was a problem hiding this comment.
Hi @StormLiangMS, I checked the test_bgp_update_timer.py script, it's the existing test for validating dut performance on handling single bgp update(single route for one time and loop test for 5 routes).
I have two concerns on using exabgp and tcpdump to implement performance test:
- How to send a large scale bgp updates in a short time by exabgp?
- If it could, then, using tcpdump to capture ingress and egress 1K bgp updates at the same time, does the tcpdump capture result reliable enough?
Please share your insights.
There was a problem hiding this comment.
@echuawu I think it is ok to have separate PR for performance and stress ones, could you open an issue to track this ask?
There was a problem hiding this comment.
@StormLiangMS , thank you, and the issue has been created to track the new PR: https://github.com/sonic-net/sonic-buildimage/issues/15194
There was a problem hiding this comment.
@echuawu could you add this new PR info to the sonic-net/SONiC#1103 to make sure it get well tracked.
There was a problem hiding this comment.
Hi @StormLiangMS , Sure done.
|
@echuawu @StormLiangMS any further open items that need to be handled or this PR can be approved? |
Hi @liat-grozovik , @StormLiangMS suggest to add a performance test. We have internal discussion about it, and decided to add another PR to handle the requrement. |
Add BGP Suppress FIB Pending test plan Change-Id: I1be42ed1bcddf0ad7ea9c45a809a89583a6554dd
Add BGP Suppress FIB Pending test plan Change-Id: I1be42ed1bcddf0ad7ea9c45a809a89583a6554dd
Add BGP Suppress FIB Pending test plan
Description of PR
Add test plan for BGP Suppress FIB Pending function added by Nvidia network team.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
#7430
Add BGP Suppress FIB Pending test plan for the test script.