Add 'ERR ntpd' to loganalyzer ignore files #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Kachur <romankac@mellanox.com>
andriymoroz-mlnx
approved these changes
Mar 6, 2019
yxieca
approved these changes
Mar 6, 2019
yxieca
pushed a commit
that referenced
this pull request
Mar 7, 2019
Signed-off-by: Roman Kachur <romankac@mellanox.com>
|
Made to 201811 branch on 3/6/2019 |
1 task
liat-grozovik
pushed a commit
that referenced
this pull request
Apr 24, 2019
…les (#865) The ntpd may generate 'ERR ntpd' in syslog and caused unnecessary test case failure. Previous PR #816 added a matching pattern of 'ERR ntpd' in loganalyzer igonre files to ignore the ntpd error messages. However, ntpd may generate two formats of error messages. The previously added matching pattern can only match one of the formats. This change is to update the pattern to match both of the formats. Signed-off-by: Xin Wang <xinw@mellanox.com>
yxieca
pushed a commit
that referenced
this pull request
Apr 26, 2019
…les (#865) The ntpd may generate 'ERR ntpd' in syslog and caused unnecessary test case failure. Previous PR #816 added a matching pattern of 'ERR ntpd' in loganalyzer igonre files to ignore the ntpd error messages. However, ntpd may generate two formats of error messages. The previously added matching pattern can only match one of the formats. This change is to update the pattern to match both of the formats. Signed-off-by: Xin Wang <xinw@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roman Kachur romankac@mellanox.com
Description of PR
Summary:
The fact that ntpd daemon produces sporadical ERR messages into syslog
https://github.com/ntp-project/ntp/issues/23
becames false positive condition for Loganalyzer,
which analyzes syslog and fails test with:
ERR ntpd[7534]: routing socket reports: No buffer space availableType of change
Approach
How did you do it?
I added ntpd ERR to Loganalyzer excluded lists
roles/test/files/tools/loganalyzer/loganalyzer_common_ignore.txt roles/test/tasks/acl/acltb_ignore_messages.txt roles/test/tasks/fib/fib_ignore_messages.txt roles/test/tasks/lag/lag_ignore_messages.txt roles/test/tasks/pfc_wd/config_test/config_test_ignore_messages roles/test/tasks/pfc_wd/functional_test/ignore_pfc_wd_messagesHow did you verify/test it?
Taking a piece of syslog with
I initiated Loganalyzer
python loganalyzer.py --action analyze --logs /tmp/syslog --run_id mgtest.2019-02-06.20:56:15 --out_dir /tmp/mgtest.2019-02-05.20:20:35 -m loganalyzer_common_match.txt -i loganalyzer_common_ignore.txt -e loganalyzer_common_expect.txt -vwhich finished clear
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation