[lag_rate] Restore lag setting on VMs in case of failure in test #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing script does not restore lag rate setting on VMs in case of failure. This improvement is to restore lag setting on VMs if the testing failed. Signed-off-by: Xin Wang <xinw@mellanox.com>
mykolaf
approved these changes
Mar 28, 2019
liat-grozovik
approved these changes
Mar 28, 2019
yxieca
pushed a commit
that referenced
this pull request
Mar 28, 2019
The existing script does not restore lag rate setting on VMs in case of failure. This improvement is to restore lag setting on VMs if the testing failed. Signed-off-by: Xin Wang <xinw@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
The existing script does not restore lag rate setting on VMs in case
of failure. This improvement is to restore lag setting on VMs if the
testing failed.
Type of change
Approach
How did you do it?
Wrap the lag rate testing code in
block. Addalwayssection to restore VMs settings in case the settings are not restored in testing.How did you verify/test it?
Tested on Mellanox platform.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
Documentation