[acltb] Apply BGP ACL forward rules in acltb_test_rules_part_1.json #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanblyschak
force-pushed
the
acl_bgp_rule
branch
2 times, most recently
from
7c0752c to
88fdaae
Compare
After applying acltb_test_rules_part_1.json BGP sessions may go down before we apply acltb_test_rules_part_2.json (which had BGP ACL forward rules); This results in BGP flap during ptf test run; It is safer to apply BGP ACL forward rules first to avoid BGP flapping. Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
stepanblyschak
force-pushed
the
acl_bgp_rule
branch
from
88fdaae to
11ac034
Compare
andriymoroz-mlnx
approved these changes
Mar 28, 2019
liat-grozovik
approved these changes
Mar 28, 2019
yxieca
pushed a commit
that referenced
this pull request
Mar 28, 2019
…842) After applying acltb_test_rules_part_1.json BGP sessions may go down before we apply acltb_test_rules_part_2.json (which had BGP ACL forward rules); This results in BGP flap during ptf test run; It is safer to apply BGP ACL forward rules first to avoid BGP flapping. Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After applying acltb_test_rules_part_1.json BGP sessions may go down
before we apply acltb_test_rules_part_2.json (which had BGP ACL forward
rules); This results in BGP flap during ptf test run;
It is safer to apply BGP ACL forward rules first to avoid BGP flapping.
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
After applying acltb_test_rules_part_1.json BGP sessions may go down
before we apply acltb_test_rules_part_2.json (which had BGP ACL forward
rules); This results in BGP flap during ptf test run;
It is safer to apply BGP ACL forward rules first to avoid BGP flapping.
How did you do it?
How did you verify/test it?
Run ACL test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation