[GCU E2E Testing] Fix ECN GCU Test #8652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should skip the test case if the platform or version is not supported. I also opened a PR to address the same issue #8649 |
|
We may still see test failure on image without this change sonic-net/sonic-utilities#2857 |
xwjiang-ms
approved these changes
Jun 19, 2023
Discussed offline to move forward with this PR, and this change will only be tested on images that have sonic-utilities PR 2857. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # Issue 8648: [GCU] Undefined variable in test_ecn_config_updates
Type of change
Test Case Fix
Back port request
Approach
What is the motivation for this PR?
Patch should be applied before conditional so that we can read output in both branches to determine if patch application behavior is as expected
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation