[warm-reboot] increase warm-reboot sniffing time #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some test setup has delay in the IO path, the original sniff wait time doesn't guarantee all 36000 packet were received. Increasing sniffing wait time by 30 seconds. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
stepanblyschak
approved these changes
May 2, 2019
|
@stepanblyschak better syncing sounds great. 30 seconds extra test is ok but not great. If we could have a better mechanism to avoid increasing timeout, I am all for that! :-) |
yxieca
added a commit
that referenced
this pull request
May 6, 2019
Some test setup has delay in the IO path, the original sniff wait time doesn't guarantee all 36000 packet were received. Increasing sniffing wait time by 30 seconds. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Type of change
Approach
How did you do it?
With the original wait time, we couldn't receive all 36000 fast probing packets sent by warm-reboot
test. If any packet were delayed/re-ordered by the test infrastructure, the test would mis-judge the
missing packets as dropped packets. Therefore causing false positives. Increase the wait time by 30
seconds, in my tests, all 36000 packet were received and therefore no false positives.
Signed-off-by: Ying Xie ying.xie@microsoft.com
How did you verify/test it?