[Snappi] Update test PFC pause frame functionality to include DUT counter polling #9847

developfast · 2023-09-06T00:02:31Z

Description of PR

Summary: Currently, all verification for PFC pause frames are done by polling the ixia device at the end of the test. We need to add functionality to poll the appropriate counters on the DUT while the DUT continues to receive PFC pause frames from the neighboring device.

This PR is dependent on #9775.

Fixes (issue) #9843

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

201911
202012
202205

Approach

What is the motivation for this PR?

Poll DUT on top on ixia when the test runs

How did you do it?

How did you verify/test it?

Tested on lab device

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

…into tx_rx_check_test

…dut_pfc_fix

mssonicbld · 2023-09-06T00:03:33Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/common/snappi_tests/traffic_generation.py Fixing tests/snappi_tests/pfc/files/helper.py fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/common/snappi_tests/snappi_test_params.py:30:121: E501 line too long (122 > 120 characters) tests/common/snappi_tests/snappi_test_params.py:33:121: E501 line too long (123 > 120 characters) tests/common/snappi_tests/snappi_test_params.py:34:121: E501 line too long (124 > 120 characters) tests/common/snappi_tests/traffic_generation.py:359:121: E501 line too long (139 > 120 characters) ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

neethajohn · 2023-09-20T16:05:01Z

tests/common/snappi_tests/common_helpers.py

@@ -821,6 +823,42 @@ def get_pfc_frame_count(duthost, port, priority, is_tx=False):
    return int(pause_frame_count.replace(',', ''))


+def get_tx_frame_count(duthost, port):


unify these 2 functions - get_tx_frame_count and get_rx_frame_count

unified in #9775. this PR is dependent on that PR.

mssonicbld · 2023-10-24T09:54:54Z

@developfast PR conflicts with 202012 branch

mssonicbld · 2023-10-24T09:54:55Z

@developfast PR conflicts with 202205 branch

…nter polling (sonic-net#9847) Summary: Currently, all verification for PFC pause frames are done by polling the ixia device at the end of the test. We need to add functionality to poll the appropriate counters on the DUT while the DUT continues to receive PFC pause frames from the neighboring device. This PR is dependent on sonic-net#9775. Fixes (issue) sonic-net#9843

mssonicbld · 2023-10-24T09:55:02Z

Cherry-pick PR to 202305: #10450

…nter polling (#9847) Summary: Currently, all verification for PFC pause frames are done by polling the ixia device at the end of the test. We need to add functionality to poll the appropriate counters on the DUT while the DUT continues to receive PFC pause frames from the neighboring device. This PR is dependent on #9775. Fixes (issue) #9843

…h_snappi Signed-off-by: Austin Pham <austinpham@microsoft.com>

chore: migrate sonic-net#15002 to multidut_helper Signed-off-by: Austin Pham <austinpham@microsoft.com> chore: fix disable_pfcwd Signed-off-by: Austin Pham <austinpham@microsoft.com> chore: migrate sonic-net#9847 to test_multidut_pfc_pause_lossless_with_snappi Signed-off-by: Austin Pham <austinpham@microsoft.com>

chore: migrate sonic-net#11704 to multidut_helper chore: migrate sonic-net#15002 to multidut_helper Signed-off-by: Austin Pham <austinpham@microsoft.com> chore: fix disable_pfcwd Signed-off-by: Austin Pham <austinpham@microsoft.com> chore: migrate sonic-net#9847 to test_multidut_pfc_pause_lossless_with_snappi Signed-off-by: Austin Pham <austinpham@microsoft.com>

Description of PR Summary: Fixes # (issue) 31085729 Migrate the following PR: [Snappi] Update test PFC pause frame functionality to include DUT counter polling #9847 Fixed the failure of test_valid_pfc_frame_with_snappi.py in Cisco DUT #15002 [Snappi] Bug fix for checking counters to account for forwarding lag #11704 Approach What is the motivation for this PR? Migrate PRs for pfc test cases to t2 Signed-off-by: Austin Pham <austinpham@microsoft.com>

Description of PR Summary: Fixes # (issue) 31085729 Migrate the following PR: [Snappi] Update test PFC pause frame functionality to include DUT counter polling sonic-net#9847 Fixed the failure of test_valid_pfc_frame_with_snappi.py in Cisco DUT sonic-net#15002 [Snappi] Bug fix for checking counters to account for forwarding lag sonic-net#11704 Approach What is the motivation for this PR? Migrate PRs for pfc test cases to t2 Signed-off-by: Austin Pham <austinpham@microsoft.com>

developfast and others added 16 commits August 30, 2023 21:45

pfc counter checker changed

c9cc46a

tx_ok and rx_ok checker ready

1f3e4ae

fixed placement of functions

b886204

fixed comments on snappi test params

920d74e

Fix whitespace issue

acee992

Update flake checker

50ed8d2

Update traffic_generation.py

e032737

Update test_pfc_pause_lossless_with_snappi.py

b7091bb

fixed conditional and added regex for counting

c9afb0a

Merge branch 'tx_rx_check_test' of github.com:developfast/sonic-mgmt …

fb709e7

…into tx_rx_check_test

removed whitespace

1a9ea54

trimmed whitespace

fd3e33d

Merge branch 'master' of github.com:developfast/sonic-mgmt into poll_…

8de1d48

…dut_pfc_fix

pfc pause params separation

9d4ab10

overlap testgap for pfc frame - wip

5b15228

poll dut for pfc verification

0c8fe09

developfast added Request for 202012 branch Request for 202205 branch Request for 202305 branch labels Sep 6, 2023

developfast requested a review from neethajohn September 6, 2023 00:02

developfast added 2 commits September 6, 2023 00:12

fix pre-commit checkers

c921bb0

re-reference global vars

f58ed07

neethajohn reviewed Sep 20, 2023

View reviewed changes

neethajohn approved these changes Oct 2, 2023

View reviewed changes

neethajohn merged commit 56ccc70 into sonic-net:master Oct 2, 2023

wangxin added Approved for 202012 branch Approved for 202205 branch Approved for 202305 branch labels Oct 24, 2023

mssonicbld added the Cherry Pick Conflict_202012 label Oct 24, 2023

mssonicbld added the Cherry Pick Conflict_202205 label Oct 24, 2023

mssonicbld added the Created PR to 202305 branch label Oct 24, 2023

mssonicbld mentioned this pull request Oct 24, 2023

[action] [PR:9847] [Snappi] Update test PFC pause frame functionality to include DUT counter polling #10450

Merged

6 tasks

mssonicbld added Included in 202305 branch and removed Created PR to 202305 branch labels Oct 26, 2023

auspham added a commit to auspham/sonic-mgmt that referenced this pull request Jan 28, 2025

chore: migrate sonic-net#9847 to test_multidut_pfc_pause_lossless_wit…

ad74d3f

…h_snappi Signed-off-by: Austin Pham <austinpham@microsoft.com>

auspham added a commit to auspham/sonic-mgmt that referenced this pull request Jan 28, 2025

chore: migrate sonic-net#9847 to test_multidut_pfc_pause_lossless_wit…

e1157f1

…h_snappi Signed-off-by: Austin Pham <austinpham@microsoft.com>

auspham added a commit to auspham/sonic-mgmt that referenced this pull request Jan 28, 2025

chore: migrate sonic-net#9847 to test_multidut_pfc_pause_lossless_wit…

7b0dfd6

…h_snappi Signed-off-by: Austin Pham <austinpham@microsoft.com>

auspham mentioned this pull request Jan 28, 2025

[t0 t1 merge] Migrate multidut pfc to t2 #16694

Merged

11 tasks

mssonicbld mentioned this pull request Feb 7, 2025

[action] [PR:16694] [t0 t1 merge] Migrate multidut pfc to t2 #16853

Open

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Snappi] Update test PFC pause frame functionality to include DUT counter polling #9847

[Snappi] Update test PFC pause frame functionality to include DUT counter polling #9847

developfast commented Sep 6, 2023

mssonicbld commented Sep 6, 2023

neethajohn Sep 20, 2023

developfast Sep 22, 2023

mssonicbld commented Oct 24, 2023

mssonicbld commented Oct 24, 2023

mssonicbld commented Oct 24, 2023

		@@ -821,6 +823,42 @@ def get_pfc_frame_count(duthost, port, priority, is_tx=False):
		return int(pause_frame_count.replace(',', ''))


		def get_tx_frame_count(duthost, port):

[Snappi] Update test PFC pause frame functionality to include DUT counter polling #9847

[Snappi] Update test PFC pause frame functionality to include DUT counter polling #9847

Conversation

developfast commented Sep 6, 2023

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld commented Sep 6, 2023

neethajohn Sep 20, 2023

Choose a reason for hiding this comment

developfast Sep 22, 2023

Choose a reason for hiding this comment

mssonicbld commented Oct 24, 2023

mssonicbld commented Oct 24, 2023

mssonicbld commented Oct 24, 2023