Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonic_eeprom] Refactor State DB-related functionality #169

Open
jleveque opened this issue Feb 13, 2021 · 0 comments
Open

[sonic_eeprom] Refactor State DB-related functionality #169

jleveque opened this issue Feb 13, 2021 · 0 comments
Labels
Cleanup EEPROM Help Wanted

Comments

@jleveque
Copy link
Contributor

jleveque commented Feb 13, 2021 •
edited
Loading

  • Use swsscommon rather than direct Redis library access
  • All tabular printing functions should use the tabulate module
  • Should the library have functionality to read from DB, or only write? Or should even writing be offloaded elsewhere?
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this issue Oct 25, 2024
@jleveque
[xcvrd] Gracefully handle improper 'specification_compliance' field; …
7f01b2c 
…also fix other potential bugs (sonic-net#169)

#### Description

Gracefully handle improper 'specification_compliance' field; also fix other potential bugs and adjust some style

#### Motivation and Context
The 'specification_compliance' field of transceiver info is expected to be a string representation of a dictionary. However, there is a chance, upon some kind of platform issue that a vendor's platform API returns something like 'N/A'. In this case, xcrvd would crash. Rather than crash, xcvrd should handle this gracefully and log a warning message instead.

Also fixed a couple potential bugs where `default_dict` was being compared to `0`, when it should have been `len(default_dict)`

Also rename some constants using uppercase naming convention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cleanup EEPROM Help Wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jleveque