[ChassisBase][ModuleBase] Remove redundant 'get_serial_number()' method #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jleveque
added a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Oct 14, 2020
…t get_serial_number() methods (#2343) No longer test deprecated get_serial_number() methods of Chassis and Module classes The get_serial_number() methods are redundant and are being removed in sonic-net/sonic-platform-common#130
vdahiya12
approved these changes
Oct 14, 2020
Merged
3 tasks
mprabhu-nokia
pushed a commit
to mprabhu-nokia/sonic-platform-common
that referenced
this pull request
Oct 21, 2020
…od (sonic-net#130) ChassisBase and ModuleBase inherit from the DeviceBase class, which already provides a get_serial() method. Thus, these methods were redundant.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
…alizeGlobalConfig (sonic-net#130) The check for multiAsic before calling initializeGlobalConfig was done in xcvrd earlier. Adding now to the other processes in sonic-platform-daemons as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChassisBase and ModuleBase inherit from the DeviceBase class, which already provides a
get_serial()method. Thus, these methods were redundant.