[sffbase] Make convert_hex_to_string() compatible with both Python 2 and Python 3 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snider-nokia: Please test and review. |
|
Indeed, this fix works, Joe. Thanks. |
jleveque
added a commit
that referenced
this pull request
Feb 10, 2021
…and Python 3 (#165) When called with Python 3, `str.strip(binascii.unhexlify(ret_str))` will raise an exception: ` descriptor 'strip' requires a 'str' object but received a 'bytes'`. This patch (`binascii.unhexlify(ret_str).decode("utf-8").strip()`) will work properly with both Python 2 and Python 3. Fixes #160
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
… table for Y cable (sonic-net#165) This PR fixes the naming convention for firmware related fields for Y cable. In particular all the fields are now named as tor_self and tor_peer in place of tor1 and tor 2 Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com Description This PR fixes the naming convention for firmware related fields for Y cable. In particular all the fields are now named as tor_self and tor_peer in place of tor1 and tor 2 Motivation and Context Required by telemetry team as part of their initial schema Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When called with Python 3,
str.strip(binascii.unhexlify(ret_str))will raise an exception:descriptor 'strip' requires a 'str' object but received a 'bytes'. This patch (binascii.unhexlify(ret_str).decode("utf-8").strip()) will work properly with both Python 2 and Python 3.Fixes #160