[sonic_y_cable]: Decorate all method for mux simulator #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
jleveque
approved these changes
Mar 30, 2021
3 tasks
wangxin
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Apr 1, 2021
What is the motivation for this PR? XCVRD runs some methods which attempt to read from cable hardware. This hardware doesn't exist for mux simulator, so XCVRD writes many errors to the syslog. How did you do it? Implement mocks for all methods in sonic_y_cable to prevent errors from being generated. How did you verify/test it? Inject new mux_simulator_client to dual ToR device with changes from sonic-net/sonic-platform-common#181. Verify PMON and mux containers stay up, and show mux status output looks normal. Initiate CLI switchover and confirm show mux status output reflects switchover. Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
nirmalya-keysight
pushed a commit
to nirmalya-keysight/sonic-mgmt
that referenced
this pull request
Apr 5, 2021
What is the motivation for this PR? XCVRD runs some methods which attempt to read from cable hardware. This hardware doesn't exist for mux simulator, so XCVRD writes many errors to the syslog. How did you do it? Implement mocks for all methods in sonic_y_cable to prevent errors from being generated. How did you verify/test it? Inject new mux_simulator_client to dual ToR device with changes from sonic-net/sonic-platform-common#181. Verify PMON and mux containers stay up, and show mux status output looks normal. Initiate CLI switchover and confirm show mux status output reflects switchover. Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
saravanansv
pushed a commit
to saravanansv/sonic-mgmt
that referenced
this pull request
May 6, 2021
What is the motivation for this PR? XCVRD runs some methods which attempt to read from cable hardware. This hardware doesn't exist for mux simulator, so XCVRD writes many errors to the syslog. How did you do it? Implement mocks for all methods in sonic_y_cable to prevent errors from being generated. How did you verify/test it? Inject new mux_simulator_client to dual ToR device with changes from sonic-net/sonic-platform-common#181. Verify PMON and mux containers stay up, and show mux status output looks normal. Initiate CLI switchover and confirm show mux status output reflects switchover. Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
What is the motivation for this PR? XCVRD runs some methods which attempt to read from cable hardware. This hardware doesn't exist for mux simulator, so XCVRD writes many errors to the syslog. How did you do it? Implement mocks for all methods in sonic_y_cable to prevent errors from being generated. How did you verify/test it? Inject new mux_simulator_client to dual ToR device with changes from sonic-net/sonic-platform-common#181. Verify PMON and mux containers stay up, and show mux status output looks normal. Initiate CLI switchover and confirm show mux status output reflects switchover. Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
Xcvrd crashes when pushing QSFP DD DOM info to state DB.
#### Description
**xcvrd crash log:**
“May 6 05:12:37.446235 S1G2 ERR pmon#xcvrd[5292]: This functionality is currently not implemented for this platform”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee lawlee@microsoft.com
Description
Use the
@hook_y_cable_simulatordecorator for all methods iny_cable.pyMotivation and Context
Decorating all methods (including those that read from hardware) allow us to mock these methods in the mux simulator client and prevent XCVRD from generating errors when run with the mux simulator.
How Has This Been Tested?
Copied changes to a dual ToR testbed with mux simulator, verified normal operation.
Additional Information (Optional)