[python coverage] fix result color bar #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pettershao-ragilenetworks <pettershao@ragilenetworks.com>
jleveque
suggested changes
Jun 25, 2021
jleveque
reviewed
Jun 29, 2021
jleveque
previously approved these changes
Jun 29, 2021
jleveque
reviewed
Jun 29, 2021
azure-pipelines.yml
Outdated
| curl -sSL https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add - | ||
| sudo apt-add-repository https://packages.microsoft.com/debian/10/prod | ||
| sudo apt-get update | ||
| sudo apt-get -y install -f |
There was a problem hiding this comment.
This now works, but I don't fully understand why we need this line immediately after the sudo apt-get update call.
@pettershao-ragilenetworks: Can you please help understand why this is needed?
There was a problem hiding this comment.
@jleveque yea, I am checking.
There was a problem hiding this comment.
But I don't see any of those packages mentioned in the output of sudo apt-get -y install -f. Plus, this command is usually used after a package install fails due to missing dependencies. I've never needed to run it immediately after adding a new repository.
There was a problem hiding this comment.
yea, strange, i have do some test in sonic-net/sonic-snmpagent#215 try to install dependent libs, but no success.
There was a problem hiding this comment.
after many testing, 'sudo apt-get -y install -f' can and only can be set at this place.
There was a problem hiding this comment.
Understood, but do you understand why it is necessary? What is it fixing?
There was a problem hiding this comment.
As Luoqi mentioned, -f fix below:
I compared the log with previous one, and the previous one seems suspicious
2021-06-29T03:04:13.8494132Z The following additional packages will be installed:
2021-06-29T03:04:13.8499448Z libhiredis0.14
2021-06-29T03:04:13.8986264Z The following packages will be REMOVED:
2021-06-29T03:04:13.8993644Z libibverbs-dev libnl-3-dev libnl-route-3-dev libopenmpi-dev
2021-06-29T03:04:13.9005991Z The following packages will be upgraded:
2021-06-29T03:04:13.9011224Z libhiredis0.14
2021-06-29T03:04:13.9242794Z 1 upgraded, 0 newly installed, 4 to remove and 2 not upgraded.
The new apt source messed up the local package database.
and i try to do some experimenents, but all not work:
(snmpagent repo)
put add source at begin, build failed:
https://dev.azure.com/mssonic/build/_build/results?buildId=21862&view=logs&j=83516c17-6666-5250-abde-63983ce72a49&t=c10d5f44-55ce-55d7-7975-407ed75d9a96
remove source and only wget debs, build failed:
https://dev.azure.com/mssonic/build/_build/results?buildId=21866&view=logs&j=83516c17-6666-5250-abde-63983ce72a49&t=c10d5f44-55ce-55d7-7975-407ed75d9a96
try dotnet-install.sh, no error but no color bar:
https://dev.azure.com/mssonic/build/_build/results?buildId=21868&view=logs&j=83516c17-6666-5250-abde-63983ce72a49&t=c10d5f44-55ce-55d7-7975-407ed75d9a96
|
@jleveque fixed, help forward this! |
lguohan
approved these changes
Jul 19, 2021
5 tasks
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jul 22, 2021
To include: > e168f1d 2021-07-19 pettershao-ragilenetworks: [python coverage] fix result color bar (sonic-net/sonic-platform-common#202) > 87c81de 2021-07-13 Prince George: Fix Xcvrd crash due to invalid key access in type_of_media_interface, host_electrical_interface, connector_dict (sonic-net/sonic-platform-common#206) > 4533f82 2021-06-21 ngoc-do: Add a template function that returns list of asics on module (sonic-net/sonic-platform-common#185) > 1e860c5 2021-06-18 Aravind Mani: Fix decode error when parsing EEPROM fields (sonic-net/sonic-platform-common#199) > 93641f3 2021-06-17 Sujin Kang: Unifying the platform api for get_pcie_aer_stats with PcieBase (sonic-net/sonic-platform-common#197)
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
To include: > e168f1d 2021-07-19 pettershao-ragilenetworks: [python coverage] fix result color bar (sonic-net/sonic-platform-common#202) > 87c81de 2021-07-13 Prince George: Fix Xcvrd crash due to invalid key access in type_of_media_interface, host_electrical_interface, connector_dict (sonic-net/sonic-platform-common#206) > 4533f82 2021-06-21 ngoc-do: Add a template function that returns list of asics on module (sonic-net/sonic-platform-common#185) > 1e860c5 2021-06-18 Aravind Mani: Fix decode error when parsing EEPROM fields (sonic-net/sonic-platform-common#199) > 93641f3 2021-06-17 Sujin Kang: Unifying the platform api for get_pcie_aer_stats with PcieBase (sonic-net/sonic-platform-common#197)
judyjoseph
pushed a commit
that referenced
this pull request
Aug 20, 2021
fix python gcov warning "Please install dotnet core to enable automatic generation of Html report" more info check: sonic-net/sonic-snmpagent#215 Signed-off-by: pettershao-ragilenetworks <pettershao@ragilenetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fix python gcov warning "Please install dotnet core to enable automatic generation of Html report"
more info check: sonic-net/sonic-snmpagent#215
How I did it
install dotnet core
How to verify it