[sfp-refactor] Add initial support for SFF-8436 in sonic_xcvr #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 4 alerts when merging 3178734 into a09f5a3 - view on LGTM.com new alerts:
|
prgeor
requested changes
Sep 8, 2021
|
This pull request introduces 4 alerts when merging dbdb276 into a09f5a3 - view on LGTM.com new alerts:
|
|
"/azp run" |
prgeor
approved these changes
Sep 20, 2021
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
Due to rare timing issue test_sfp_insert_events failure can fail. Out of 100 iterations, the test failed on 82nd iteration. Signed-off-by: Prince George <prgeor@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds basic support for the SFF-8436 transceiver spec within the new sonic_xcvr package.
It also defines and implements some new helper functions in XcvrApi.
Motivation and Context
See the HLD: sonic-net/SONiC#786
How Has This Been Tested?
Added new unit test under tests/sonic_xcvr
Verified API calls on an Arista platform
Additional Information (Optional)