split i2c read across pages #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prince George <prgeor@microsoft.com>
vdahiya12
previously approved these changes
Jan 5, 2022
|
@prgeor can you check build failure?. |
aravindmani-1
previously approved these changes
Jan 5, 2022
aravindmani-1
approved these changes
Jan 5, 2022
vdahiya
approved these changes
Jan 5, 2022
vdahiya
approved these changes
Jan 5, 2022
vdahiya12
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prince George prgeor@microsoft.com
Description
Fix crash in get_transceiver_info() issue #255
Motivation and Context
Reading register fields across multiple page can result in crash. So, we split the read such that each field grouped are within the same page. This way we can skip reading page >= 01h for passive modules like DAC cable.
How Has This Been Tested?
Verified on 400G DAC cable and AOC cable
Additional Information (Optional)