Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EEPROM/DOM Info: The Compliance Code will show "unknown" by using FINISAR 10G LR XCVR #319

Merged
merged 3 commits into from
Nov 23, 2022
Merged

EEPROM/DOM Info: The Compliance Code will show "unknown" by using FINISAR 10G LR XCVR #319

merged 3 commits into from
Nov 23, 2022

Conversation

chiourung
Copy link
Contributor

@chiourung chiourung commented Oct 31, 2022 •
edited
Loading

correct the code mapping

Description

The Specification compliance is wrong

root@sonic:/home/admin# show interfaces transceiver eeprom Ethernet51
Ethernet51: SFP EEPROM detected
        Application Advertisement: N/A
        Connector: LC
        DOM Capability:
                Rx_power_support: True
                Temp_support: True
                Tx_power_support: True
                Voltage_support: True
        Encoding: 64B/66B
        Extended Identifier: GBIC/SFP defined by two-wire interface ID
        Extended RateSelect Compliance: Unknown
        Identifier: SFP/SFP+/SFP28
        Length SMF (100m): 100.0
        Nominal Bit Rate(100Mbs): 103
        Specification compliance:
                10G Ethernet Compliance: Unknown
                ESCON Compliance: Unknown
                Ethernet Compliance: Unknown
                Fibre Channel Link Length: Unknown
                Fibre Channel Speed: Unknown
                Fibre Channel Transmission Media: Unknown
                Fibre Channel Transmitter Technology: Unknown
                Infiniband Compliance: Unknown
                SFP+CableTechnology: Unknown
                SONET Compliance Codes: Unknown
        Vendor Date Code(YYYY-MM-DD Lot): 2019-01-15
        Vendor Name: FINISAR CORP.
        Vendor OUI: 00-90-65
        Vendor PN: FTLX1471D3BCL
        Vendor Rev: A
        Vendor SN: A13A8YL

Motivation and Context

How Has This Been Tested?

Additional Information (Optional)

@chiourung
JIRA-SONIC-5341: [eBay_ec202111_214] EEPROM/DOM Info: The Compliance …
00e6a93 
…Code will show "unknown" by using FINISAR 10G LR XCVR

correct the code mapping
@chiourung chiourung changed the title JIRA-SONIC-5341: [eBay_ec202111_214] EEPROM/DOM Info: The Compliance … EEPROM/DOM Info: The Compliance Code will show "unknown" by using FINISAR 10G LR XCVR Oct 31, 2022
@prgeor
Copy link
Collaborator

prgeor commented Nov 18, 2022

@chiourung thanks for fixing this. Can you also fix POWER_CLASSES, CLEI_CODE, CDR_TX, CDR_RX, FIBRE_CHANNEL_LINK_LENGTH, FIBRE_CHANNEL_TRANSMITTER_TECH, FIBRE_CHANNEL_TRANSMISSION_MEDIA, FIBRE_CHANNEL_SPEED in sonic_platform_base/sonic_xcvr/codes/public/sff8436.py or better if you can put them in common place in sff8024.py

@prgeor prgeor self-assigned this Nov 18, 2022
@prgeor prgeor self-requested a review November 18, 2022 03:34
@prgeor prgeor merged commit ce9aacb into sonic-net:master Nov 23, 2022
@prgeor
Copy link
Collaborator

prgeor commented Nov 23, 2022

@chiourung Thanks for fixing these

yxieca pushed a commit that referenced this pull request Nov 29, 2022
@chiourung @yxieca
EEPROM/DOM Info: The Compliance Code will show "unknown" by using FIN…
47f87d9 
…ISAR 10G LR XCVR (#319)

* JIRA-SONIC-5341: [eBay_ec202111_214] EEPROM/DOM Info: The Compliance Code will show "unknown" by using FINISAR 10G LR XCVR

correct the code mapping

* Fix others error code mapping and add unit test
@chiourung chiourung deleted the fix_Compliance_Code branch February 7, 2023 05:44
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
@vdahiya12
[ycabled] fix minor appl_db retrieving logic for update (sonic-net#319)
e474335 
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
This PR fixes the app DB access fix logic by updating the values causing some failures for ycabled's response for mux probe from linkmgrd.
This PR essentially fixes that logic, calling the correct method to access the app DB
self.appl_db -> self.table_helper.get_appl_db()

Description
Motivation and Context
How Has This Been Tested?
UT and deploying changes to kvm

Additional Information (Optional)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prgeor prgeor prgeor approved these changes

Assignees

@prgeor prgeor

Labels
Bug Included in 202205 Branch Request for 202205 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chiourung @prgeor @yxieca