Added new RegBitsFields #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andywongarista can you review? |
mihirpat1
approved these changes
Aug 8, 2023
andywongarista
approved these changes
Aug 8, 2023
vdahiya12
approved these changes
Aug 8, 2023
|
lgtm, maybe add a few more description about why we need such new field. |
lguohan
approved these changes
Aug 8, 2023
|
@StormLiangMS @yxieca please help cherry pick |
|
@prgeor is this bug fix or enhancement? |
StormLiangMS
pushed a commit
that referenced
this pull request
Sep 4, 2023
|
Missing this will cause advance submodule build failure. |
noaOrMlnx
pushed a commit
to noaOrMlnx/sonic-platform-common
that referenced
this pull request
Sep 20, 2023
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
…el; fix missing namespaces in delete event handle (sonic-net#391) * [ycabled][active-active] Correct the behavior when no active-active cable type Signed-off-by: vaibhav dahiya <vdahiya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new field RegBitsField. This will allow read/write single or more bits in a group of fields.
Motivation and Context
This allows to write fields that are 1bit or more but < 1 Byte
How Has This Been Tested?
Added unit test for different bit sizes.
Additional Information (Optional)