Support for static and dynamic attrs as part of stormond implementation #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assrinivasan
changed the title
assrinivasan
requested review from
Junchao-Mellanox,
keboliu,
prgeor and
Staphylo
assrinivasan
changed the title
assrinivasan
changed the title
assrinivasan
force-pushed
the
ssdmon-common
branch
from
d729e0c
to
c235350
Compare
|
@assrinivasan PR description says unit test pending |
|
@assrinivasan please fix the build failure |
prgeor
reviewed
May 14, 2024
assrinivasan
changed the title
prgeor
reviewed
May 15, 2024
prgeor
reviewed
May 15, 2024
dgsudharsan
suggested changes
May 22, 2024
Junchao-Mellanox
suggested changes
May 22, 2024
Junchao-Mellanox
suggested changes
May 22, 2024
dgsudharsan
suggested changes
May 23, 2024
dgsudharsan
suggested changes
May 23, 2024
dgsudharsan
suggested changes
May 24, 2024
dgsudharsan
approved these changes
May 24, 2024
|
@assrinivasan "How Has This Been Tested?" Add the output one for each utility you modified? |
prgeor
reviewed
May 24, 2024
prgeor
reviewed
May 24, 2024
There was a problem hiding this comment.
@assrinivasan please make sure we are able to build sonic image for all platforms.
…temperature parsing.
…ied child class implementation accordingly
storage_devices.py: Moved imports to the beginning of file renamed function to _storage_device_object_factory Above function now returns an object storage_common.py: Changed logic to only get reads and writes using psutil library.
Changed parse_id_number logic to prevent phantom regex matches
Fixed a bug in parse_id_number that was causing the code to disregard vendor_ssd_info
Fixed issues with Innodisk and Virtium parsers
Fixed a ValueError bug in Virtium parser logic
Added UTs to test the various changes
assrinivasan
force-pushed
the
ssdmon-common
branch
from
6964ae1
to
67e5cae
Compare
Added as attachments to the PR |
https://dev.azure.com/mssonic/build/_build/results?buildId=557473&view=results -- Verified that we are able to successfully build for all platforms. |
dgsudharsan
approved these changes
May 29, 2024
Junchao-Mellanox
suggested changes
May 29, 2024
10 tasks
prgeor
reviewed
May 29, 2024
There was a problem hiding this comment.
@assrinivasan please use SysLogger as direct usage of logger pollutes the identifier name for others daemons
Junchao-Mellanox
approved these changes
May 29, 2024
Done in latest. |
prgeor
reviewed
May 30, 2024
prgeor
reviewed
May 30, 2024
prgeor
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the ssdutil class to now be able to fetch the following information:
It also adds support for Micron and Intel storage devices.
Motivation and Context
This is a sister PR to the stormond implementation.
SONiC Storage Monitoring Daemon HLD
How Has This Been Tested?
Has been manually tested on following platforms:
Arista-7050CX3
Mellanox-SN2700
Dell-S6100
Additional Information (Optional)
Verified that build was successful and ssdutil output was unaffected:
7050cx3.txt
S6100.txt
SN2700.txt