Platform APIs for SmartSwitch #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chassis_base.py" to support SmartSwitch
vvolam
reviewed
Jun 18, 2024
|
LGTM. I have two small requests, but besides that, all is good. |
oleksandrivantsiv
approved these changes
Aug 8, 2024
vvolam
reviewed
Aug 8, 2024
prgeor
reviewed
Aug 8, 2024
vvolam
added a commit
to vvolam/SONiC
that referenced
this pull request
Aug 9, 2024
vvolam
reviewed
Aug 12, 2024
sonic_platform_base/chassis_base.py
Outdated
| def get_module_dpu_data_port(self, index): | ||
| """ | ||
| Retrieves the DPU data port NPU-DPU association represented for | ||
| the DPU index. Platforms that need to overwrite the hwsku.json |
There was a problem hiding this comment.
Are we going to use platform.json or hwsku.json?
There was a problem hiding this comment.
We are going to use platform.json
vvolam
approved these changes
Aug 12, 2024
prgeor
reviewed
Aug 19, 2024
prgeor
approved these changes
Aug 20, 2024
prgeor
changed the title
vvolam
added a commit
to vvolam/SONiC
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new APIs and enhanced the required APIs in "module_base.py and chassis_base.py" to support SmartSwitch
Description
The ChassisBase class and ModuleBase class need to support new SmartSwitch platforms.
Motivation and Context
Some new API and some API enhancements are required to support SmartSwitch. This has been captured in the PMON HLD document. These changes are implementation based on those requirements.
How Has This Been Tested?
The corresponding platform APIs were implemented. The new CLI changes and chassisd changes invoke these APIs. UT was performed and demo was done.
Additional Information (Optional)