Fetch firmware versions for Cmis Target FW upgrade supported cables #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
|
@mihirpat1 type in PR description -> "E1 and E1 targets " |
prgeor
reviewed
Apr 23, 2024
| @@ -75,8 +75,8 @@ def get_transceiver_info_firmware_versions(self): | |||
| Retrieves active and inactive firmware versions of the xcvr | |||
|
|
|||
| Returns: | |||
| A list with active and inactive firmware versions of the xcvr | |||
| [active_firmware, inactive_firmware] | |||
| A dictionary containing the active and inactive firmware versions of the transceiver | |||
There was a problem hiding this comment.
@AnoopKamath please note this change for your PR...
prgeor
reviewed
Apr 23, 2024
|
|
||
| TARGET_LIST = [TARGET_E0_VALUE, TARGET_E1_VALUE, TARGET_E2_VALUE] | ||
|
|
||
| AEC_E1_FIRMWARE_INFO_MAP = { |
There was a problem hiding this comment.
@mihirpat1 rename AEC -> CABLE?
| 'server_firmware': 'e1_server_firmware' | ||
| } | ||
|
|
||
| AEC_E2_FIRMWARE_INFO_MAP = { |
There was a problem hiding this comment.
@mihirpat1 rename AEC -> CABLE?
There was a problem hiding this comment.
@prgeor I have addressed this now.
| Returns: | ||
| A dictionary of the firmware versions for all targets. | ||
| """ | ||
| def get_transceiver_info_firmware_versions(self): |
There was a problem hiding this comment.
@mihirpat1 is this going to be called for cmis optics not supporting remote end fw upgrade?
There was a problem hiding this comment.
@prgeor No, this implementation will be invoked only for CMIS optics supporting remote end FW upgrade.
Comment on lines
134
to
141
| server_fw_version_str = '' | ||
| for i in range(0, SERVER_FW_VERSION_SIZE, SERVER_FW_VERSION_NUMBER_SIZE): | ||
| server_fw_version_number = bytes(server_fw_version_byte_array[i:i+SERVER_FW_VERSION_NUMBER_SIZE]) | ||
| # Each number of the server firmware version is 4 bytes and is stored in big endian format. | ||
| # Convert the 4 bytes to a number and then convert the number to a string. | ||
| server_fw_version_str += str(struct.unpack('>I', server_fw_version_number)[0]) + '.' | ||
| server_fw_version_str = server_fw_version_str[:-1] | ||
| return_dict['server_firmware'] = server_fw_version_str |
There was a problem hiding this comment.
@mihirpat1 can we encapsulate this calculation in server version memmap?
There was a problem hiding this comment.
For eg. you can check the implementation of DateField field in xcvrd_field.py which return the date in string format.
There was a problem hiding this comment.
@prgeor I have addressed this now.
prgeor
approved these changes
Apr 25, 2024
|
@StormLiangMS @yxieca Can you please help in merging this to 202305 and 202311? |
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-common
that referenced
this pull request
Apr 26, 2024
…onic-net#455) * Fetch firmware versions for Cmis Target FW upgrade supported cables Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Enhanced unit-test for exception handling while reading target firmware version * Addressed PR comments and moved server firmware version info to xcvr_field --------- Signed-off-by: Mihir Patel <patelmi@microsoft.com>
|
Cherry-pick PR to 202311: #459 |
mssonicbld
pushed a commit
that referenced
this pull request
Apr 26, 2024
…455) * Fetch firmware versions for Cmis Target FW upgrade supported cables Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Enhanced unit-test for exception handling while reading target firmware version * Addressed PR comments and moved server firmware version info to xcvr_field --------- Signed-off-by: Mihir Patel <patelmi@microsoft.com>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-common
that referenced
this pull request
May 4, 2024
…onic-net#455) * Fetch firmware versions for Cmis Target FW upgrade supported cables Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Enhanced unit-test for exception handling while reading target firmware version * Addressed PR comments and moved server firmware version info to xcvr_field --------- Signed-off-by: Mihir Patel <patelmi@microsoft.com>
|
Cherry-pick PR to 202305: #464 |
mssonicbld
pushed a commit
that referenced
this pull request
May 4, 2024
…455) * Fetch firmware versions for Cmis Target FW upgrade supported cables Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Enhanced unit-test for exception handling while reading target firmware version * Addressed PR comments and moved server firmware version info to xcvr_field --------- Signed-off-by: Mihir Patel <patelmi@microsoft.com>
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
Ignore processing the front panel ports in xcvrd. This include ports with suffixes other than Ethernet and ports that have role field set to any value other than Ext. Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With onboarding of CMIS target firmware upgrade supported transceivers, we need a mechanism to store the firmware version of E1 and E2 targets (in addition to E0 target) in redis-db. The current change set is for accomplishing this task.
XCVRD will be able to push the target firmware version information to TRANSCEIVER_FIRMWARE_INFO table of STATE_DB.
MSFT ADO - 26565884
Motivation and Context
This change is required to periodically read target firmware versions and store it in TRANSCEIVER_FIRMWARE_INFO table of STATE_DB.
How Has This Been Tested?
Following scenarios were tested
1.1 CLI output on transceiver not supporting Target FW upgrade
1.2 XCVR on target 1 removed
1.3 XCVR on target 2 removed
1.4 All targets having different inactive firmware versions
1.5 CLI output on transceiver not supporting Target FW upgrade
1.6 CLI on port with DOM disabled
Additional Information (Optional)