-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse all VDM advertised fields during DOM monitoring #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@qinchuanares Can you please help in reviewing this? |
qinchuanares
approved these changes
Jul 30, 2024
prgeor
approved these changes
Aug 1, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-common
that referenced
this pull request
Aug 1, 2024
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
Cherry-pick PR to 202405: #487 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 1, 2024
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Aug 1, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-common
that referenced
this pull request
Aug 2, 2024
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
Cherry-pick PR to 202311: #488 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 2, 2024
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are multiple VDM observable types which are not being updated in redis-db (
TRANSCEIVER_DOM_SENSOR
table) during DOM monitoring. Hence, these fields need to be monitored periodically.Motivation and Context
Added the missing VDM fields to be monitored as part of periodic DOM polling. Also, reading the fields based on lane id.
How Has This Been Tested?
show interface transceiver eeprom -d EthernetXX
does not change with the current changesetTRANSCEIVER_DOM_SENSOR
table.redis-db dump
EEPROM DOM CLI output
Additional Information (Optional)
MSFT ADO - 28751849