Change Virtium SSD which doesn't support SmartCMD, to use only smartctl #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-platform-common |
|
/AzurePipelines run Azure.sonic-platform-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@wangxin A kind reminder, can you please handle the failure which is caused by moving from Bullseye to Bookworm? |
|
/azpw run Azure.sonic-platform-common |
|
/AzurePipelines run Azure.sonic-platform-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
keboliu
previously approved these changes
Dec 24, 2024
|
@prgeor can you please take a look? |
assrinivasan
suggested changes
Dec 27, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
noaOrMlnx
changed the title
noaOrMlnx
force-pushed
the
special_virtium_ssd
branch
from
3604c4d to
4d16199
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
keboliu
previously approved these changes
Jan 7, 2025
noaOrMlnx
force-pushed
the
special_virtium_ssd
branch
from
4d16199 to
46f1905
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Virtium SSD which can't use SmartCMD - to use only smartctl (using generic ssd info parser).
Motivation and Context
There are Virtium SSDs which can't receive SSD info from 'SmartCMD', and must use 'smartctl' command.
For those SSDs, after calling the generic ssd parser, the function is finished and the specific vendor parser won't be called.
How Has This Been Tested?
I tested it manually with a special Virtium SSD which doesn't support SmartCMD
Additional Information (Optional)
output after the change:
root@sonic:/home/admin# show platform ssdhealth
Device Model : Virtium VTPM24CEXI080-BM110006
Health : 100.0%
Temperature : 45.0C
output before the change:
root@sonic:/home/admin# show platform ssdhealth
[Error] Cannot read SMART information on device /dev/nvme0n1
Disk Type : NVME
Device Model : Virtium VTPM24CEXI080-BM110006
Health : N/A
Temperature : 51.0C