Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Add validation for thermal policy #78

Merged
merged 2 commits into from
Mar 17, 2020

Conversation

Junchao-Mellanox
Copy link
Contributor

Add validation for thermal policy file:

  1. validate duplicate/empty thermal condition
  2. validate duplicate/empty thermal policy
  3. validate thermal policy with same condition but different actions

@jleveque jleveque merged commit dc59b10 into sonic-net:master Mar 17, 2020
@Junchao-Mellanox Junchao-Mellanox deleted the thermal-fix branch May 7, 2020 06:05
Junchao-Mellanox added a commit to Junchao-Mellanox/sonic-platform-common that referenced this pull request Jun 1, 2020
@abdosi
Copy link
Contributor

abdosi commented Jun 16, 2020

@Junchao-Mellanox is this still needed for 201911. I assumed it is already merge via direct PR 201911.

@rlhui @liat-grozovik

@Junchao-Mellanox
Copy link
Contributor Author

It is already merge via direct PR 201911.

oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
…ic-net#78)

Merge of QSFP-DD support via PR# sonic-net#66
is making xcvrd to bail out on platforms that do not support
new key/attribute.

Fix is to ignore new key/attribute if not present/supported yet.

Fix takes changes done as part of PR#sonic-net#76 which can be closed
once this gets merged

Verified manually xcvrd running fine after above changes.
also command show interface transceiver is showing correct o/p

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants