-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[component]: Introduce new firmware management API #82
Merged
liat-grozovik
merged 4 commits into
sonic-net:master
from
nazariig:master-component-firmware-api
Apr 30, 2020
Merged
[component]: Introduce new firmware management API #82
liat-grozovik
merged 4 commits into
sonic-net:master
from
nazariig:master-component-firmware-api
Apr 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
nazariig
requested review from
liat-grozovik,
volodymyrsamotiy,
jleveque and
sujinmkang
April 13, 2020 15:38
jleveque
suggested changes
Apr 14, 2020
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
sujinmkang
approved these changes
Apr 28, 2020
jleveque
approved these changes
Apr 28, 2020
liat-grozovik
approved these changes
Apr 29, 2020
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@nazariig create PR for 201911 . Cherry-pick is not happening as there is some issue with merge commit |
This was referenced Jun 11, 2020
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
…asses (sonic-net#82) Previous commit to transition to importing sonic-py-common accidentally replaced all `logger` instances in xcvrd with `self`, although not all of these instances resided in the `DaemonXcvrd` class, breaking them. Here we add a global Logger instance for these references to use. Eventually we should refactor so that there is only one Logger instance created by xcvrd, not two. - Also rename class names using PascalCase for consistency across the codebase. - Also add Logger instance to ThermalMonitor class in thermalctld
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn nazariig@mellanox.com
Summary:
The purpose of this PR is to propagate some new component firmware management APIs which are intended to make the process more versatile. These new API's will be used mostly to extend
fwutil
functionality in order to support new platform components (e.g, SSD).Motivation:
fwutil
to read component firmware version directly from image instead of configuration file if not provided