Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component]: Introduce new firmware management API #82

Merged

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Apr 13, 2020

Signed-off-by: Nazarii Hnydyn nazariig@mellanox.com

Summary:
The purpose of this PR is to propagate some new component firmware management APIs which are intended to make the process more versatile. These new API's will be used mostly to extend fwutil functionality in order to support new platform components (e.g, SSD).

Motivation:

  1. Inform user in advance about required component firmware update actions when operating in manual mode
  2. Allow fwutil to read component firmware version directly from image instead of configuration file if not provided

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
sonic_platform_base/component_base.py Outdated Show resolved Hide resolved
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@liat-grozovik liat-grozovik merged commit 28c39c5 into sonic-net:master Apr 30, 2020
@abdosi
Copy link
Contributor

abdosi commented May 1, 2020

@nazariig create PR for 201911 . Cherry-pick is not happening as there is some issue with merge commit

@nazariig
Copy link
Collaborator Author

@abdosi Done: #87

oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
…asses (sonic-net#82)

Previous commit to transition to importing sonic-py-common accidentally replaced all `logger` instances in xcvrd with `self`, although not all of these instances resided in the `DaemonXcvrd` class, breaking them. Here we add a global Logger instance for these references to use. Eventually we should refactor so that there is only one Logger instance created by xcvrd, not two.

- Also rename class names using PascalCase for consistency across the codebase.
- Also add Logger instance to ThermalMonitor class in thermalctld
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants